From 11b66650ac46bf7518d02074d2a4e2c72879eb43 Mon Sep 17 00:00:00 2001 From: Xinyuan Lin Date: Tue, 20 Oct 2026 21:07:04 -0700 Subject: [PATCH] refactor(frontend): remove dataset version creator dead code isCreateButtonDisabled is never written, so drop it and its always- false operand in the create button's [disabled] binding. Drop the unused FormBuilder injection, and the .file-uploader and .help-text rules that no element in this template has. --- .../user-dataset-version-creator.component.html | 2 +- .../user-dataset-version-creator.component.scss | 13 ------------- .../user-dataset-version-creator.component.ts | 7 ++----- 3 files changed, 3 insertions(+), 19 deletions(-) diff --git a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.html b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.html index 8320f91772d..485db691082 100644 --- a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.html +++ b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.html @@ -55,7 +55,7 @@ nz-button nzType="primary" (click)="onClickCreate()" - [disabled]="isCreateButtonDisabled || isCreating" + [disabled]="isCreating" class="create-btn"> Create diff --git a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.scss b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.scss index c6d9dda556a..a597dd6dbc1 100644 --- a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.scss +++ b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.scss @@ -55,12 +55,6 @@ } } -.file-uploader { - height: 40%; - width: 90%; - margin: auto; -} - .dataset-toggles { margin-top: 16px; margin-bottom: 16px; @@ -76,11 +70,4 @@ min-width: 80px; font-weight: 500; } - - .help-text { - margin-left: 8px; - font-size: 12px; - color: #999; - font-style: italic; - } } diff --git a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.ts b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.ts index 1eb40dc608a..326185d10f4 100644 --- a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.ts +++ b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.ts @@ -18,7 +18,7 @@ */ import { Component, inject, OnInit } from "@angular/core"; -import { FormBuilder, FormGroup, FormsModule } from "@angular/forms"; +import { FormGroup, FormsModule } from "@angular/forms"; import { FormlyFieldConfig, FormlyModule } from "@ngx-formly/core"; import { DatasetService } from "../../../../../service/user/dataset/dataset.service"; import { Dataset } from "../../../../../../common/type/dataset"; @@ -58,8 +58,6 @@ export class UserDatasetVersionCreatorComponent implements OnInit { readonly did: number = inject(NZ_MODAL_DATA)?.did ?? undefined; - isCreateButtonDisabled: boolean = false; - public form: FormGroup = new FormGroup({}); model: any = {}; fields: FormlyFieldConfig[] = []; @@ -75,8 +73,7 @@ export class UserDatasetVersionCreatorComponent implements OnInit { constructor( private modalRef: NzModalRef, private datasetService: DatasetService, - private notificationService: NotificationService, - private formBuilder: FormBuilder + private notificationService: NotificationService ) {} ngOnInit() {