diff --git a/lib/appium_lib/common/helper.rb b/lib/appium_lib/common/helper.rb index 302ad73a..185840bd 100644 --- a/lib/appium_lib/common/helper.rb +++ b/lib/appium_lib/common/helper.rb @@ -257,7 +257,8 @@ def end_element(name) end def characters(chars) - return if @skip_element + # Text that follows a closed filtered element has no element to attach to. + return if @skip_element || @element_stack.empty? element = @element_stack.last element[:text] = chars diff --git a/test/regression_test.rb b/test/regression_test.rb index e09aca0d..67cf967e 100644 --- a/test/regression_test.rb +++ b/test/regression_test.rb @@ -179,6 +179,14 @@ def test_html_elements_result_continues_after_attribute_free_elements assert_equal "\na\n href: /login\n text: Sign in\n", parser.document.result end + def test_html_elements_ignores_text_after_filtered_element + parser = Nokogiri::HTML::SAX::Parser.new(Appium::Common::HTMLElements.new) + parser.document.filter = :a + parser.parse('
Sign in or register
') + + assert_equal "\na\n href: /login\n text: Sign in\n", parser.document.result + end + def test_log_event_writer_raises_no_driver_and_argument_errors driver = build_driver assert_raises(Appium::NoDriverInstanceError) { driver.log_event = { vendor: 'appium', event: 'funEvent' } }