fix: add eslint

Author: aminya

.eslintrc.json

@@ -0,0 +1,4 @@
+{
+  "extends": "eslint-config-atomic",
+  "ignorePatterns": ["dist/", "node_modules/", "lib/debugger/VendorLib"]
+}

.github/workflows/CI.yml

@@ -47,8 +47,8 @@ jobs:
       - name: Format ✨
         run: npm run test.format
 
-      # - name: Lint ✨
-      #   run: npm run test.lint
+      - name: Lint ✨
+        run: npm run test.lint
 
   Release:
     needs: [Test]

babel.config.js

@@ -1,10 +1,10 @@
-let presets = ["babel-preset-atomic"]
+const presets = ["babel-preset-atomic"]
 
-let plugins = []
+const plugins = []
 
 module.exports = {
-  presets: presets,
-  plugins: plugins,
+  presets,
+  plugins,
   exclude: ["node_modules/**", "lib/debugger/VendorLib/**"],
   sourceMap: "inline",
 }

lib/main.js

@@ -7,7 +7,7 @@ import { createDebuggerProvider, activate as debuggerActivate, dispose as debugg
 
 // Ref: https://github.com/nteract/hydrogen/blob/master/lib/autocomplete-provider.js#L33
 // adapted from http://stackoverflow.com/q/5474008
-const PYTHON_REGEX = /(([^\d\W]|[\u00A0-\uFFFF])[\w.\u00A0-\uFFFF]*)|\.$/
+const PYTHON_REGEX = /(([^\W\d]|[\u00A0-\uFFFF])[\w.\u00A0-\uFFFF]*)|\.$/
 
 class PythonLanguageClient extends AutoLanguageClient {
   activate() {
@@ -62,7 +62,7 @@ class PythonLanguageClient extends AutoLanguageClient {
     const venvPath = (await detectPipEnv(projectPath)) || (await detectVirtualEnv(projectPath))
     const pylsEnvironment = Object.assign({}, process.env)
     if (venvPath) {
-      pylsEnvironment["VIRTUAL_ENV"] = venvPath
+      pylsEnvironment.VIRTUAL_ENV = venvPath
     }
     this.python = replacePipEnvPathVar(atom.config.get("ide-python.python"), venvPath)
 
@@ -114,7 +114,9 @@ class PythonLanguageClient extends AutoLanguageClient {
   }
 
   async getSuggestions(request) {
-    if (!PYTHON_REGEX.test(request.prefix)) return null
+    if (!PYTHON_REGEX.test(request.prefix)) {
+      return null
+    }
     return super.getSuggestions(request)
   }
 
@@ -125,7 +127,7 @@ class PythonLanguageClient extends AutoLanguageClient {
 
   createTimeoutPromise(milliseconds) {
     return new Promise((resolve, reject) => {
-      let timeout = setTimeout(() => {
+      const timeout = setTimeout(() => {
         clearTimeout(timeout)
         this.logger.error(`Server failed to shutdown in ${milliseconds}ms, forcing termination`)
         resolve()

lib/utils.js

@@ -32,17 +32,17 @@ async function detectVirtualEnv(path) {
     })
   )
   if (entries) {
-    for (let entry of entries) {
+    for (const entry of entries) {
       if (entry.isDirectory()) {
         if (VIRTUAL_ENV_BIN_DIRS.indexOf(entry.getBaseName()) !== -1) {
-          for (let executable of VIRTUAL_ENV_EXECUTABLES) {
+          for (const executable of VIRTUAL_ENV_EXECUTABLES) {
             if (await entry.getFile(executable).exists()) {
               return path
             }
           }
         } else {
-          for (let dir_name of VIRTUAL_ENV_BIN_DIRS) {
-            for (let executable of VIRTUAL_ENV_EXECUTABLES) {
+          for (const dir_name of VIRTUAL_ENV_BIN_DIRS) {
+            for (const executable of VIRTUAL_ENV_EXECUTABLES) {
               if (await entry.getSubdirectory(dir_name).getFile(executable).exists()) {
                 return entry.getPath()
               }

package.json

@@ -37,8 +37,7 @@
     "babel": "npm run clean && shx cp -r lib dist && cross-env NODE_ENV=production cross-env BABEL_KEEP_MODULES=false babel dist --out-dir dist",
     "copy": "shx cp -r lib/debugger/VendorLib dist/debugger",
     "build": "npm run babel",
-    "build-commit": "build-commit -o dist",
-    "prepare": "npm run build"
+    "build-commit": "build-commit -o dist"
   },
   "package-deps": [
     "atom-ide-base"
@@ -80,6 +79,7 @@
     "babel-preset-atomic": "^4.2.0",
     "build-commit": "0.1.4",
     "cross-env": "^7.0.3",
+    "eslint-config-atomic": "^1.16.2",
     "mock-spawn": "0.2.6",
     "prettier-config-atomic": "^2.0.5",
     "shx": "^0.3.3"