changes to promise

Author: asturur

lib/views/directory-select.js

@@ -45,15 +45,13 @@ export default class DirectorySelect extends React.Component {
     );
   }
 
-  chooseDirectory = () => new Promise(resolve => {
+  chooseDirectory = () =>
     this.props.showOpenDialog(this.props.currentWindow, {
       defaultPath: this.props.buffer.getText(),
       properties: ['openDirectory', 'createDirectory', 'promptToCreate'],
-    }, filePaths => {
-      if (filePaths !== undefined) {
+    }).then(({filePaths}) => {
+      if (filePaths.length) {
         this.props.buffer.setText(filePaths[0]);
       }
-      resolve();
     });
-  });
 }

lib/views/git-timings-view.js

@@ -328,9 +328,9 @@ class WaterfallWidget extends React.Component {
     const buffer = new TextBuffer({text: json});
     dialog.showSaveDialog({
       defaultPath: 'git-timings.json',
-    }, filename => {
-      if (!filename) { return; }
-      buffer.saveAs(filename);
+    }).then(({filePath}) => {
+      if (!filePath) { return; }
+      buffer.saveAs(filePath);
     });
   }
 }
@@ -423,9 +423,9 @@ export default class GitTimingsView extends React.Component {
     e.preventDefault();
     dialog.showOpenDialog({
       properties: ['openFile'],
-    }, async filenames => {
-      if (!filenames) { return; }
-      const filename = filenames[0];
+    }).then(async ({filePaths}) => {
+      if (!filePaths.length) { return; }
+      const filename = filePaths[0];
       try {
         const contents = await fs.readFile(filename, {encoding: 'utf8'});
         const data = JSON.parse(contents);

test/views/directory-select.test.js

@@ -24,7 +24,7 @@ describe('DirectorySelect', function() {
       <DirectorySelect
         currentWindow={atomEnv.getCurrentWindow()}
         buffer={buffer}
-        showOpenDialog={() => {}}
+        showOpenDialog={() => Promise.resolve()}
         tabGroup={new TabGroup()}
         {...override}
       />

test/worker-manager.test.js

@@ -167,7 +167,7 @@ describe('WorkerManager', function() {
       });
       `;
 
-      await new Promise(resolve => browserWindow.webContents.executeJavaScript(script, resolve));
+      await browserWindow.webContents.executeJavaScript(script);
 
       workerManager.destroy(true);
       workerManager = new WorkerManager();