Further build noise reduction. Relates to github #2026

Author: dghgit

core/src/main/java/org/bouncycastle/asn1/gm/GMObjectIdentifiers.java

@@ -50,7 +50,7 @@ public interface GMObjectIdentifiers
 
     /**
      * <Information security technology — Cryptographic application identifier criterion specification>
-     * <url>http://c.gb688.cn/bzgk/gb/showGb?type=online&hcno=252CF0F72A7BE339A56DEA7D774E8994</url>,
+     * <url>http://c.gb688.cn/bzgk/gb/showGb?type=online&hcno=252CF0F72A7BE339A56DEA7D774E8994</url>,
      * Page 21 only cover from 301.1 to 301.3
      * */
     ASN1ObjectIdentifier wapip192v1 =  sm_scheme.branch("301.101");

core/src/main/java/org/bouncycastle/math/ec/ECCurve.java

@@ -692,6 +692,7 @@ public static class Fp extends AbstractFp
          * @deprecated use constructor taking order/cofactor
          */
         @Deprecated
+        @SuppressWarnings("InlineMeSuggester")
         public Fp(BigInteger q, BigInteger a, BigInteger b)
         {
             this(q, a, b, null, null);
@@ -1155,6 +1156,7 @@ public static class F2m extends AbstractF2m
          * @deprecated use constructor taking order/cofactor
          */
         @Deprecated
+        @SuppressWarnings("InlineMeSuggester")
         public F2m(
             int m,
             int k,
@@ -1214,6 +1216,7 @@ public F2m(
          * @deprecated use constructor taking order/cofactor
          */
         @Deprecated
+        @SuppressWarnings("InlineMeSuggester")
         public F2m(
             int m,
             int k1,

core/src/main/java/org/bouncycastle/pqc/crypto/crystals/dilithium/DilithiumPrivateKeyParameters.java

@@ -64,6 +64,7 @@ public byte[] getK()
 
     /** @deprecated Use {@link #getEncoded()} instead. */
     @Deprecated
+    @SuppressWarnings("InlineMeSuggester")
     public byte[] getPrivateKey()
     {
         return getEncoded();

core/src/main/java/org/bouncycastle/pqc/crypto/mldsa/MLDSAPrivateKeyParameters.java

@@ -157,6 +157,7 @@ public byte[] getK()
      * @deprecated Use {@link #getEncoded()} instead.
      */
     @Deprecated
+    @SuppressWarnings("InlineMeSuggester")
     public byte[] getPrivateKey()
     {
         return getEncoded();

core/src/main/java/org/bouncycastle/pqc/crypto/sphincsplus/SPHINCSPlusParameters.java

@@ -194,6 +194,7 @@ public static SPHINCSPlusParameters getParams(Integer id)
      * @deprecated Use {@link #getID()} instead
      */
     @Deprecated
+    @SuppressWarnings("InlineMeSuggester")
     public static Integer getID(SPHINCSPlusParameters params)
     {
         return params.getID();

mail/src/main/java/org/bouncycastle/mail/smime/validator/SignedMailValidator.java

@@ -24,6 +24,7 @@
 import java.util.Iterator;
 import java.util.LinkedHashSet;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
 
@@ -83,6 +84,8 @@ public class SignedMailValidator
     private static final int KU_DIGITAL_SIGNATURE = 0;
     private static final int KU_NON_REPUDIATION = 1;
 
+    private static final Locale locale = Locale.getDefault();
+
     private CertStore certs;
 
     private SignerInformationStore signers;
@@ -106,7 +109,7 @@ public class SignedMailValidator
      *
      * @param message the signed {@link MimeMessage}.
      * @param param the parameters for the certificate path validation.
-     * @throws {@link SignedMailValidatorException} if the message is not a signed message or if an
+     * @throws SignedMailValidatorException if the message is not a signed message or if an
      * exception occurs reading the message.
      */
     public SignedMailValidator(MimeMessage message, PKIXParameters param) throws SignedMailValidatorException
@@ -132,7 +135,7 @@ public SignedMailValidator(MimeMessage message, PKIXParameters param) throws Sig
      * constructor.
      * @throws SignedMailValidatorException if the message is not a signed message or if an exception
      * occurs reading the message.
-     * @throws {@link IllegalArgumentException} if the certPathReviewerClass is not a subclass of
+     * @throws IllegalArgumentException if the certPathReviewerClass is not a subclass of
      * {@link PKIXCertPathReviewer} or objects of certPathReviewerClass can not be instantiated.
      */
     public SignedMailValidator(MimeMessage message, PKIXParameters param, Class certPathReviewerClass)
@@ -377,7 +380,7 @@ public static Set getEmailAddresses(X509Certificate cert) throws IOException, Ce
             {
                 if (PKCSObjectIdentifiers.pkcs_9_at_emailAddress.equals(atVs[j].getType()))
                 {
-                    String email = ((ASN1String)atVs[j].getValue()).getString().toLowerCase();
+                    String email = ((ASN1String)atVs[j].getValue()).getString().toLowerCase(locale);
                     addresses.add(email);
                 }
             }
@@ -394,7 +397,7 @@ public static Set getEmailAddresses(X509Certificate cert) throws IOException, Ce
                 GeneralName name = names[i];
                 if (name.getTagNo() == GeneralName.rfc822Name)
                 {
-                    String email = ASN1IA5String.getInstance(name.getName()).getString().toLowerCase();
+                    String email = ASN1IA5String.getInstance(name.getName()).getString().toLowerCase(locale);
                     addresses.add(email);
                 }
             }
@@ -496,7 +499,7 @@ static boolean hasAnyFromAddress(Set certEmails, String[] fromAddresses)
         // check if email in cert is equal to the from address in the message
         for (int i = 0; i < fromAddresses.length; ++i)
         {
-            if (certEmails.contains(fromAddresses[i].toLowerCase()))
+            if (certEmails.contains(fromAddresses[i].toLowerCase(locale)))
             {
                 return true;
             }

mls/src/main/java/org/bouncycastle/mls/TreeKEM/TreeKEMPublicKey.java

@@ -391,6 +391,7 @@ public LeafNode getLeafNode(LeafIndex index)
         return node.getLeafNode();
     }
 
+    @SuppressWarnings("NonApiType")
     public ArrayList<NodeIndex> resolve(NodeIndex index)
     {
         boolean atLeaf = (index.level() == 0);

mls/src/main/java/org/bouncycastle/mls/codec/GroupContext.java

@@ -2,6 +2,7 @@
 
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.List;
 
 import org.bouncycastle.mls.crypto.MlsCipherSuite;
 
@@ -28,12 +29,12 @@ public byte[] getConfirmedTranscriptHash()
         return confirmedTranscriptHash;
     }
 
-    public ArrayList<Extension> getExtensions()
+    public List<Extension> getExtensions()
     {
         return extensions;
     }
 
-    public GroupContext(MlsCipherSuite ciphersuite, byte[] groupID, long epoch, byte[] treeHash, byte[] confirmedTranscriptHash, ArrayList<Extension> extensions)
+    public GroupContext(MlsCipherSuite ciphersuite, byte[] groupID, long epoch, byte[] treeHash, byte[] confirmedTranscriptHash, List<Extension> extensions)
     {
         this.suite = ciphersuite;
         this.ciphersuite = ciphersuite.getSuiteID();

mls/src/main/java/org/bouncycastle/mls/protocol/Group.java

@@ -56,7 +56,7 @@
 public class Group
 {
 
-    public class GroupWithMessage
+    public static class GroupWithMessage
     {
         public Group group;
         public MLSMessage message;
@@ -393,7 +393,7 @@ public MlsCipherSuite getSuite()
         return suite;
     }
 
-    public ArrayList<Extension> getExtensions()
+    public List<Extension> getExtensions()
     {
         return extensions;
     }

pg/src/main/java/org/bouncycastle/bcpg/PublicKeyPacket.java

@@ -221,6 +221,7 @@ private void parseKey(BCPGInputStream in, int algorithmId, long optLen)
      * @deprecated use versioned {@link #PublicKeyPacket(int, int, Date, BCPGKey)} instead
      */
     @Deprecated
+    @SuppressWarnings("InlineMeSuggester")
     public PublicKeyPacket(
         int algorithm,
         Date time,