From 0a8a5c0ec3dba39344112325c9f0146e3b16a8a8 Mon Sep 17 00:00:00 2001 From: Charles Lowell Date: Fri, 13 Nov 2026 14:23:42 -0600 Subject: [PATCH] Add Node.isConnected with upstream WPT coverage --- .changeset/dom-is-connected.md | 5 +++++ packages/ui/src/dom.ts | 11 +++++++++++ packages/ui/test/wpt.config.ts | 1 + 3 files changed, 17 insertions(+) create mode 100644 .changeset/dom-is-connected.md diff --git a/.changeset/dom-is-connected.md b/.changeset/dom-is-connected.md new file mode 100644 index 0000000..ee6b608 --- /dev/null +++ b/.changeset/dom-is-connected.md @@ -0,0 +1,5 @@ +--- +'@clack/ui': patch +--- + +Add Node.isConnected by walking the node's ancestry to its owner document's root. diff --git a/packages/ui/src/dom.ts b/packages/ui/src/dom.ts index 95493cb..3e89e5e 100644 --- a/packages/ui/src/dom.ts +++ b/packages/ui/src/dom.ts @@ -265,6 +265,17 @@ export abstract class Node extends EventTarget { return null; } + get isConnected(): boolean { + const { documentElement } = this.ownerDocument; + // oxlint-disable-next-line typescript/no-this-alias -- This cursor walks the node's ancestry. + for (let current: Node | null = this; current; current = current.parentNode) { + if (current === documentElement) { + return true; + } + } + return false; + } + appendChild(node: Node): Node { return this.insertBefore(node, null); } diff --git a/packages/ui/test/wpt.config.ts b/packages/ui/test/wpt.config.ts index 13e5088..a1da355 100644 --- a/packages/ui/test/wpt.config.ts +++ b/packages/ui/test/wpt.config.ts @@ -179,6 +179,7 @@ const config: WPTConfig = { 'Attribute with prefix in local name', 'getAttributeNames tests', ], + 'dom/nodes/Node-isConnected.html': true, 'dom/nodes/Node-nodeValue.html': ['Text.nodeValue', 'Comment.nodeValue'], 'dom/nodes/Node-textContent.html': [ 'For an empty Text, textContent should be the empty string',