switch to prophecy in tests

Author: Stephan Wentz

composer.json

@@ -15,7 +15,8 @@
     },
     "require-dev": {
         "mikey179/vfsStream": "~1.2",
-        "phpunit/phpunit": "~4.5"
+        "phpunit/phpunit": "~4.5",
+        "symfony/http-foundation": "~2.3"
     },
     "autoload": {
         "psr-4": { "Brainbits\\Blocking\\": "src/" }

tests/Adapter/FilesystemAdapterTest.php

@@ -12,10 +12,12 @@
 namespace Brainbits\Blocking\Tests\Adapter;
 
 use Brainbits\Blocking\Adapter\FilesystemAdapter;
+use Brainbits\Blocking\Owner\OwnerInterface;
 use PHPUnit_Framework_TestCase as TestCase;
 use org\bovigo\vfs\vfsStream;
 use Brainbits\Blocking\Block;
 use Brainbits\Blocking\Identifier\Identifier;
+use Prophecy\Prophecy\ObjectProphecy;
 
 /**
  * Filesystem adapter test
@@ -34,19 +36,20 @@ class FilesystemAdapterTest extends TestCase
      */
     private $root;
 
+    /**
+     * @var OwnerInterface|ObjectProphecy
+     */
+    private $ownerMock;
+
     public function setUp()
     {
         vfsStream::setup('blockDir');
 
         $this->root = vfsStream::url('blockDir');
         $this->adapter = new FilesystemAdapter($this->root);
-        $this->ownerMock = $this->getMockBuilder('Brainbits\Blocking\Owner\OwnerInterface')
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->ownerMock
-            ->expects($this->any())
-            ->method('__toString')
-            ->will($this->returnValue('dummyOwner'));
+
+        $this->ownerMock = $this->prophesize(OwnerInterface::class);
+        $this->ownerMock->__toString()->willReturn('dummyOwner');
     }
 
     public function tearDown()
@@ -59,7 +62,7 @@ public function tearDown()
     public function testWriteSucceedesOnNewFile()
     {
         $identifier = new Identifier('test', 'lock');
-        $block = new Block($identifier, $this->ownerMock, new \DateTime());
+        $block = new Block($identifier, $this->ownerMock->reveal(), new \DateTime());
 
         $result = $this->adapter->write($block);
 
@@ -76,7 +79,7 @@ public function testWriteFailsOnNonExistantDirectoryInNonWritableDirectory()
         $adapter = new FilesystemAdapter(vfsStream::url('nonWritableDir/blockDir'));
 
         $identifier = new Identifier('test', 'lock');
-        $block = new Block($identifier, $this->ownerMock, new \DateTime());
+        $block = new Block($identifier, $this->ownerMock->reveal(), new \DateTime());
 
         $adapter->write($block);
     }
@@ -92,7 +95,7 @@ public function testWriteFailsOnNonWritableDirectory()
         $adapter = new FilesystemAdapter(vfsStream::url('writableDir/nonWritableBlockDir'));
 
         $identifier = new Identifier('test', 'lock');
-        $block = new Block($identifier, $this->ownerMock, new \DateTime());
+        $block = new Block($identifier, $this->ownerMock->reveal(), new \DateTime());
 
         $adapter->write($block);
     }
@@ -104,7 +107,7 @@ public function testWriteFailsOnNonWritableDirectory()
     public function testTouchSucceedesOnExistingFile()
     {
         $identifier = new Identifier('test', 'lock');
-        $block = new Block($identifier, $this->ownerMock, new \DateTime());
+        $block = new Block($identifier, $this->ownerMock->reveal(), new \DateTime());
 
         $this->adapter->write($block);
         $result = $this->adapter->touch($block);
@@ -116,7 +119,7 @@ public function testTouchSucceedesOnExistingFile()
     public function testRemoveReturnsFalseOnNonexistingFile()
     {
         $identifier = new Identifier('test', 'unlock');
-        $block = new Block($identifier, $this->ownerMock, new \DateTime());
+        $block = new Block($identifier, $this->ownerMock->reveal(), new \DateTime());
 
         $result = $this->adapter->remove($block);
 
@@ -127,7 +130,7 @@ public function testRemoveReturnsFalseOnNonexistingFile()
     public function testUnblockReturnsTrueOnExistingFile()
     {
         $identifier = new Identifier('test', 'unlock');
-        $block = new Block($identifier, $this->ownerMock, new \DateTime());
+        $block = new Block($identifier, $this->ownerMock->reveal(), new \DateTime());
 
         $this->adapter->write($block);
         $result = $this->adapter->remove($block);
@@ -148,7 +151,7 @@ public function testExistsReturnsFalseOnNonexistingFile()
     public function testIsBlockedReturnsTrueOnExistingBlock()
     {
         $identifier = new Identifier('test', 'isblocked');
-        $block = new Block($identifier, $this->ownerMock, new \DateTime());
+        $block = new Block($identifier, $this->ownerMock->reveal(), new \DateTime());
 
         $this->adapter->write($block);
         $result = $this->adapter->exists($identifier);
@@ -168,7 +171,7 @@ public function testGetReturnsNullOnNonexistingFile()
     public function testGetReturnsBlockOnExistingFile()
     {
         $identifier = new Identifier('test', 'isblocked');
-        $block = new Block($identifier, $this->ownerMock, new \DateTime());
+        $block = new Block($identifier, $this->ownerMock->reveal(), new \DateTime());
 
         $this->adapter->write($block);
         $result = $this->adapter->get($identifier);

tests/BlockTest.php

@@ -14,6 +14,7 @@
 use Brainbits\Blocking\Block;
 use Brainbits\Blocking\Identifier\IdentifierInterface;
 use Brainbits\Blocking\Owner\OwnerInterface;
+use DateTime;
 use PHPUnit_Framework_TestCase as TestCase;
 
 /**
@@ -35,47 +36,35 @@ class BlockTest extends TestCase
 
     public function setUp()
     {
-        $this->identifierMock = $this->getMockBuilder(IdentifierInterface::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-
-        $this->ownerMock = $this->getMockBuilder(OwnerInterface::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->ownerMock
-            ->expects($this->any())
-            ->method('__toString')
-            ->will($this->returnValue('dummyOwner'));
-    }
+        $this->identifierMock = $this->prophesize(IdentifierInterface::class)->reveal();
 
-    public function tearDown()
-    {
-        $this->ownerMock = null;
-        $this->identifier = null;
+        $ownerMock = $this->prophesize(OwnerInterface::class);
+        $ownerMock->__toString()->willReturn('dummyOwner');
+        $this->ownerMock = $ownerMock->reveal();
     }
 
     public function testConstruct()
     {
-        $block = new Block($this->identifierMock, $this->ownerMock, new \DateTime());
+        $block = new Block($this->identifierMock, $this->ownerMock, new DateTime());
     }
 
     public function testGetIdentifierReturnsCorrectValue()
     {
-        $block = new Block($this->identifierMock, $this->ownerMock, new \DateTime());
+        $block = new Block($this->identifierMock, $this->ownerMock, new DateTime());
 
         $this->assertSame($this->identifierMock, $block->getIdentifier());
     }
 
     public function testGetOwnerReturnsCorrectValue()
     {
-        $block = new Block($this->identifierMock, $this->ownerMock, new \DateTime());
+        $block = new Block($this->identifierMock, $this->ownerMock, new DateTime());
 
         $this->assertSame($this->ownerMock, $block->getOwner());
     }
 
     public function testGetCreatedAtReturnsCorrectValue()
     {
-        $createdAt = new \DateTime();
+        $createdAt = new DateTime();
 
         $block = new Block($this->identifierMock, $this->ownerMock, $createdAt);
         $result = $block->getCreatedAt();
@@ -86,7 +75,7 @@ public function testGetCreatedAtReturnsCorrectValue()
 
     public function testGetUpdatedAtReturnsCreatedAtValueAfterInstanciation()
     {
-        $createdAt = new \DateTime();
+        $createdAt = new DateTime();
 
         $block = new Block($this->identifierMock, $this->ownerMock, $createdAt);
         $result = $block->getUpdatedAt();
@@ -97,11 +86,11 @@ public function testGetUpdatedAtReturnsCreatedAtValueAfterInstanciation()
 
     public function testSetUpdatedAtUpdatesValue()
     {
-        $createdAt = new \DateTime();
+        $createdAt = new DateTime();
 
         $block = new Block($this->identifierMock, $this->ownerMock, $createdAt);
 
-        $updatedAt = new \DateTime();
+        $updatedAt = new DateTime();
         $block->setUpdatedAt($updatedAt);
         $result = $block->getUpdatedAt();