Merge pull request #1 from temp/master

Fix touch test

Author: micha149

src/Brainbits/Blocking/Adapter/FilesystemAdapter.php

@@ -41,10 +41,11 @@ public function __construct($root)
      */
     public function write(BlockInterface $block)
     {
-        file_put_contents(
-            $this->getFilename($block->getIdentifier()),
-            serialize($block)
-        );
+        $filename = $this->getFilename($block->getIdentifier());
+
+        if (false === file_put_contents($filename, serialize($block))) {
+            throw new \Exception('Write failed');
+        }
 
         return true;
     }
@@ -55,7 +56,11 @@ public function write(BlockInterface $block)
     public function touch(BlockInterface $block)
     {
         $filename = $this->getFilename($block->getIdentifier());
-        touch($filename);
+
+        if (false === touch($filename)) {
+            throw new \Exception('Touch failed');
+        }
+
         $updatedAt = new \DateTime();
         $updatedAt->setTimestamp(filemtime($filename));
         $block->setUpdatedAt($updatedAt);
@@ -72,7 +77,10 @@ public function remove(BlockInterface $block)
             return false;
         }
 
-        unlink($this->getFilename($block->getIdentifier()));
+        $filename = $this->getFilename($block->getIdentifier());
+        if (false === unlink($filename)) {
+            throw new \Exception('Unlink failed');
+        }
 
         return true;
     }
@@ -82,7 +90,8 @@ public function remove(BlockInterface $block)
      */
     public function exists(IdentifierInterface $identifier)
     {
-        return file_exists($this->getFilename($identifier));
+        $filename = $this->getFilename($identifier);
+        return file_exists($filename);
     }
 
     /**

tests/Brainbits/Block/Adapter/FilesystemAdapterTest.php

@@ -96,6 +96,10 @@ public function testWriteFailsOnNonWritableDirectory()
         $adapter->write($block);
     }
 
+    /**
+     * @requires PHP 5.4
+     * in PHP 5.3 and before, vfsstream had no support for touch
+     */
     public function testTouchSucceedesOnExistingFile()
     {
         $identifier = new Identifier('test', 'lock');