From 4a17c644c22c7139e9704f523b96ca35fc05ad16 Mon Sep 17 00:00:00 2001 From: Benoit TRAVERS Date: Thu, 27 Aug 2026 09:14:59 +0200 Subject: [PATCH] ci: fix broken /beta/ docs site and stale root logo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Turbo 2.x strict env mode drops any variable a task does not declare, so DOCS_BASE and DOCS_VERSIONS never reached VitePress. The beta site built with the root base: /temporal-contract/beta/ served HTML pointing at /temporal-contract/assets/*, which 404s, rendering a blank page. The version dropdown was missing on both sites for the same reason. The root site is built from the latest stable tag (7.0.0, 2026-07-11), which predates the rebrand, so it serves the old logo. Overlay main's docs/public/ onto the stable worktree before building — every asset the tag references still exists there. --- .github/workflows/deploy-docs.yml | 4 ++++ turbo.json | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/deploy-docs.yml b/.github/workflows/deploy-docs.yml index 83c74569..fa397e6a 100644 --- a/.github/workflows/deploy-docs.yml +++ b/.github/workflows/deploy-docs.yml @@ -126,6 +126,10 @@ jobs: # (Runs with the main checkout's docs toolchain — tsx lives there.) pnpm --filter ./docs exec tsx "$GITHUB_WORKSPACE/.github/scripts/inject-docs-version-nav.ts" \ /tmp/stable-docs/docs/.vitepress + # Brand assets follow main, not the tag: the stable site is the landing page, + # and a tag cut before a rebrand would otherwise serve the old logo forever. + rm -rf /tmp/stable-docs/docs/public + cp -r docs/public /tmp/stable-docs/docs/public cd /tmp/stable-docs pnpm install --frozen-lockfile pnpm --filter ./docs exec turbo build diff --git a/turbo.json b/turbo.json index 1b91499a..179b7c6f 100644 --- a/turbo.json +++ b/turbo.json @@ -32,6 +32,10 @@ }, "@temporal-contract/docs#build": { "dependsOn": ["^build", "^build:docs"], + // deploy-docs.yml passes these to build the versioned (/beta/) site; turbo's + // strict env mode drops anything undeclared, which silently builds the beta + // site with the root base and 404s every asset. + "env": ["DOCS_BASE", "DOCS_VERSIONS"], "outputs": [".vitepress/dist/**"] }, "check:package": {