Address review comment from c4milo

ehoogerbeets · ehoogerbeets · commit e5230ad77fc8 · 2017-07-09T23:58:55.000-07:00
diff --git a/lib/json2xml.js b/lib/json2xml.js
@@ -82,7 +82,8 @@ ToXml.prototype.addAttr = function(key, val) {
 }
 ToXml.prototype.addTextContent = function(text) {
     this.completeTag();
-    this.xml += (this.options.sanitize ? sanitizer.sanitize(text) : text);
+    var newText = (this.options.sanitize ? sanitizer.sanitize(text) : text);
+    this.xml += newText;
 }
 ToXml.prototype.closeTag = function(key) {
     this.completeTag();

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,8 @@ ToXml.prototype.addAttr = function(key, val) {`
`82`	`82`	`}`
`83`	`83`	`ToXml.prototype.addTextContent = function(text) {`
`84`	`84`	`this.completeTag();`
`85`		`- this.xml += (this.options.sanitize ? sanitizer.sanitize(text) : text);`
	`85`	`+ var newText = (this.options.sanitize ? sanitizer.sanitize(text) : text);`
	`86`	`+ this.xml += newText;`
`86`	`87`	`}`
`87`	`88`	`ToXml.prototype.closeTag = function(key) {`
`88`	`89`	`this.completeTag();`