From 8b57ed04b25926dfaa6bc669d2aed1fb84c3382b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Wed, 18 Nov 2026 16:48:33 +0100 Subject: [PATCH] chore(scripts): wire check-provider-plugin into package.json scripts scripts/check-provider-plugin.mjs was an orphaned entry point referenced only by .fallowrc.json and its own usage comment, yet provider-plugin PRs still run it manually (e.g. #4579 asks for node scripts/check-provider-plugin.mjs on the packed BrowserStack plugin). Expose it as pnpm check:provider-plugin and document it next to the packed-install smoke guidance in CONTRIBUTING.md. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe --- CONTRIBUTING.md | 3 ++- package.json | 1 + scripts/check-provider-plugin.mjs | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a7f1c5642f..392e879ee8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -136,7 +136,8 @@ or through a peer dependency. Their factories receive the host from `agent-devic When adding a public package, initialize its version from the root `package.json`; the release workflow stamps the release version into every public package. An optional plugin must have no production import from the core build or production dependency in the root manifest. Run its -packed-install smoke before releasing. npm can only trust a package that exists, so a maintainer +packed-install smoke before releasing: `pnpm build && pnpm check:provider-plugin packages/`. +npm can only trust a package that exists, so a maintainer publishes an empty `0.0.0` placeholder once and grants the trust before the next nightly: ```bash diff --git a/package.json b/package.json index f82c5eb55b..a14a3aa70d 100644 --- a/package.json +++ b/package.json @@ -166,6 +166,7 @@ "check:production-exports": "fallow dead-code --config fallow-production-exports.json --production --unused-exports --fail-on-issues", "check:bundle-owner-files": "node --experimental-strip-types scripts/check-bundle-owner-files.ts", "check:package": "node --experimental-strip-types scripts/check-package.ts", + "check:provider-plugin": "node scripts/check-provider-plugin.mjs", "check:command-docs": "vitest run --project unit-core test/repo-guards/command-doc-coverage.test.ts", "check:adr-citations": "vitest run --project unit-core test/repo-guards/adr-citations.test.ts", "check:capabilities-matrix": "vitest run --project unit-core test/repo-guards/capability-matrix.test.ts", diff --git a/scripts/check-provider-plugin.mjs b/scripts/check-provider-plugin.mjs index 513aecad63..655df1a6a3 100644 --- a/scripts/check-provider-plugin.mjs +++ b/scripts/check-provider-plugin.mjs @@ -1,5 +1,5 @@ // Manual pre-push check for provider plugin packages; no CI lane runs it (it needs pnpm and a -// built core). Usage: `pnpm build && node scripts/check-provider-plugin.mjs packages/provider-testmu`. +// built core). Usage: `pnpm build && pnpm check:provider-plugin packages/provider-testmu`. // A fixture without `respond` is for a provider with no credentials: connect must pass at once. import assert from 'node:assert/strict'; import { execFile } from 'node:child_process';