Skip to content

Commit d94fcc2

Browse files
kraenhansenclaude
andcommitted
fix(host): make vendor-hermes --silent actually silent (#410)
The spinners were passed `isEnabled: !silent`. A disabled ora spinner still writes `- <text>` on start and the success/fail symbol on completion (to stderr) — it only skips the animation. `isSilent` is the option that suppresses output entirely. Callers capture stdout only (`$(... --silent)` in CI and the Gradle error message, backticks in patch-hermes.rb), so the stray output was noise rather than a broken path, but `--silent` now does what it says. Porting of a19b9e9 from next: main has a third spinner (copying JSI headers) using the same option. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent c17619d commit d94fcc2

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎packages/host/src/node/cli/hermes.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ async function patchJsiHeaders({
4444
successText: "Copied JSI from patched Hermes to React Native",
4545
failText: (err) =>
4646
`Failed to copy JSI from Hermes to React Native: ${err.message}`,
47-
isEnabled: !silent,
47+
isSilent: silent,
4848
},
4949
);
5050
}
@@ -99,7 +99,7 @@ export const command = new Command("vendor-hermes")
9999
successText: "Removed existing Hermes clone",
100100
failText: (error) =>
101101
`Failed to remove existing Hermes clone: ${error.message}`,
102-
isEnabled: !silent,
102+
isSilent: silent,
103103
},
104104
);
105105
}
@@ -128,7 +128,7 @@ export const command = new Command("vendor-hermes")
128128
successText: "Cloned custom Hermes",
129129
failText: (err) =>
130130
`Failed to clone custom Hermes: ${err.message}`,
131-
isEnabled: !silent,
131+
isSilent: silent,
132132
},
133133
);
134134
} catch (error) {

0 commit comments

Comments
 (0)