Repository navigation
Commit d94fcc2
fix(host): make vendor-hermes --silent actually silent (#410)
The spinners were passed `isEnabled: !silent`. A disabled ora spinner still
writes `- <text>` on start and the success/fail symbol on completion (to
stderr) — it only skips the animation. `isSilent` is the option that
suppresses output entirely.
Callers capture stdout only (`$(... --silent)` in CI and the Gradle error
message, backticks in patch-hermes.rb), so the stray output was noise rather
than a broken path, but `--silent` now does what it says.
Porting of a19b9e9 from next: main has a third spinner (copying JSI headers) using the same option.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>1 parent c17619d commit d94fcc2
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
| 102 | + | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
0 commit comments