Skip to content

Commit 86a4e8a

Browse files
committed
Close #129 Enable passive option in scroll handlers
1 parent 701d72d commit 86a4e8a

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

react-list.es6

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ const SIZE_KEYS = {x: 'width', y: 'height'};
2323

2424
const NOOP = () => {};
2525

26+
const PASSIVE = {passive: true};
27+
2628
module.exports = class ReactList extends Component {
2729
static displayName = 'ReactList';
2830

@@ -220,8 +222,8 @@ module.exports = class ReactList extends Component {
220222
prev.removeEventListener('scroll', this.updateFrame);
221223
prev.removeEventListener('mousewheel', NOOP);
222224
}
223-
this.scrollParent.addEventListener('scroll', this.updateFrame);
224-
this.scrollParent.addEventListener('mousewheel', NOOP);
225+
this.scrollParent.addEventListener('scroll', this.updateFrame, PASSIVE);
226+
this.scrollParent.addEventListener('mousewheel', NOOP, PASSIVE);
225227
}
226228

227229
updateSimpleFrame(cb) {

react-list.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@
100100

101101
var NOOP = function NOOP() {};
102102

103+
var PASSIVE = { passive: true };
104+
103105
_module3.default.exports = (_temp = _class = function (_Component) {
104106
_inherits(ReactList, _Component);
105107

@@ -318,8 +320,8 @@
318320
prev.removeEventListener('scroll', this.updateFrame);
319321
prev.removeEventListener('mousewheel', NOOP);
320322
}
321-
this.scrollParent.addEventListener('scroll', this.updateFrame);
322-
this.scrollParent.addEventListener('mousewheel', NOOP);
323+
this.scrollParent.addEventListener('scroll', this.updateFrame, PASSIVE);
324+
this.scrollParent.addEventListener('mousewheel', NOOP, PASSIVE);
323325
}
324326
}, {
325327
key: 'updateSimpleFrame',

0 commit comments

Comments
 (0)