Skip to content

Commit d9c08d6

Browse files
committed
0.7.20
1 parent 3c28c32 commit d9c08d6

4 files changed

Lines changed: 12 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
## 0.7.20
4+
- Fix body scroll size bug. (#117)
5+
36
## 0.7.19
47
- Add `itemSizeEstimator` prop. (#113)
58
- Add `useStaticSize` prop. (#116)

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-list",
3-
"version": "0.7.19",
3+
"version": "0.7.20",
44
"author": "Casey Foster <c@sey.me>",
55
"license": "MIT",
66
"main": "react-list.js",

react-list.es6

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,11 @@ export default class extends Component {
145145

146146
getScrollSize() {
147147
const {scrollParent} = this;
148-
const {axis} = this.props;
148+
const {body, documentElement} = document;
149+
const key = SCROLL_SIZE_KEYS[this.props.axis];
149150
return scrollParent === window ?
150-
Math.max(document.body[SCROLL_SIZE_KEYS[axis]], document.documentElement[SCROLL_SIZE_KEYS[axis]]) :
151-
scrollParent[SCROLL_SIZE_KEYS[axis]];
151+
Math.max(body[key], documentElement[key]) :
152+
scrollParent[key];
152153
}
153154

154155
hasDeterminateSize() {

react-list.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,11 @@
226226
key: 'getScrollSize',
227227
value: function getScrollSize() {
228228
var scrollParent = this.scrollParent;
229-
var axis = this.props.axis;
229+
var body = document.body;
230+
var documentElement = document.documentElement;
230231

231-
return scrollParent === window ? Math.max(document.body[SCROLL_SIZE_KEYS[axis]], document.documentElement[SCROLL_SIZE_KEYS[axis]]) : scrollParent[SCROLL_SIZE_KEYS[axis]];
232+
var key = SCROLL_SIZE_KEYS[this.props.axis];
233+
return scrollParent === window ? Math.max(body[key], documentElement[key]) : scrollParent[key];
232234
}
233235
}, {
234236
key: 'hasDeterminateSize',

0 commit comments

Comments
 (0)