phpstan level 9

opencode (opus 4.5)

Author: dominikzogg

composer.json

@@ -60,7 +60,7 @@
         "test:infection": "vendor/bin/infection --threads=$(nproc) --min-msi=100 --verbose --coverage=build/phpunit",
         "test:integration": "vendor/bin/phpunit --configuration phpunit.integration.xml --cache-directory=build/phpunit/integration.cache",
         "test:lint": "mkdir -p build && find src tests -name '*.php' -print0 | xargs -0 -n1 -P$(nproc) php -l | tee build/phplint.log",
-        "test:static-analysis": "mkdir -p build && bash -c 'vendor/bin/phpstan analyse src --no-progress --level=8 --error-format=junit | tee build/phpstan.junit.xml; if [ ${PIPESTATUS[0]} -ne \"0\" ]; then exit 1; fi'",
+        "test:static-analysis": "mkdir -p build && bash -c 'vendor/bin/phpstan analyse src --no-progress --level=9 --error-format=junit | tee build/phpstan.junit.xml; if [ ${PIPESTATUS[0]} -ne \"0\" ]; then exit 1; fi'",
         "test:unit": "vendor/bin/phpunit --coverage-text --coverage-clover=build/phpunit/clover.xml --coverage-html=build/phpunit/coverage-html --coverage-xml=build/phpunit/coverage-xml --log-junit=build/phpunit/junit.xml --cache-directory=build/phpunit/unit.cache"
     }
 }

phpstan.neon

@@ -0,0 +1 @@
+parameters:

src/ServiceFactory/Framework/ExceptionMiddlewareFactory.php

@@ -13,10 +13,19 @@ final class ExceptionMiddlewareFactory
 {
     public function __invoke(ContainerInterface $container): ExceptionMiddleware
     {
+        /** @var ResponseFactoryInterface $responseFactory */
+        $responseFactory = $container->get(ResponseFactoryInterface::class);
+
+        /** @var array{debug: bool} $config */
+        $config = $container->get('config');
+
+        /** @var LoggerInterface $logger */
+        $logger = $container->get(LoggerInterface::class);
+
         return new ExceptionMiddleware(
-            $container->get(ResponseFactoryInterface::class),
-            $container->get('config')['debug'],
-            $container->get(LoggerInterface::class)
+            $responseFactory,
+            $config['debug'],
+            $logger
         );
     }
 }

src/ServiceFactory/Framework/RouteMatcherFactory.php

@@ -13,9 +13,15 @@ final class RouteMatcherFactory
 {
     public function __invoke(ContainerInterface $container): RouteMatcherInterface
     {
+        /** @var RoutesByNameInterface $routes */
+        $routes = $container->get(RoutesByNameInterface::class);
+
+        /** @var array{fastroute: array{cache: null|string}} $config */
+        $config = $container->get('config');
+
         return new RouteMatcher(
-            $container->get(RoutesByNameInterface::class),
-            $container->get('config')['fastroute']['cache']
+            $routes,
+            $config['fastroute']['cache']
         );
     }
 }

src/ServiceFactory/Framework/RouteMatcherMiddlewareFactory.php

@@ -12,6 +12,9 @@ final class RouteMatcherMiddlewareFactory
 {
     public function __invoke(ContainerInterface $container): RouteMatcherMiddleware
     {
-        return new RouteMatcherMiddleware($container->get(RouteMatcherInterface::class));
+        /** @var RouteMatcherInterface $routeMatcher */
+        $routeMatcher = $container->get(RouteMatcherInterface::class);
+
+        return new RouteMatcherMiddleware($routeMatcher);
     }
 }

src/ServiceFactory/Framework/UrlGeneratorFactory.php

@@ -13,8 +13,9 @@ final class UrlGeneratorFactory
 {
     public function __invoke(ContainerInterface $container): UrlGeneratorInterface
     {
-        return new UrlGenerator(
-            $container->get(RoutesByNameInterface::class)
-        );
+        /** @var RoutesByNameInterface $routes */
+        $routes = $container->get(RoutesByNameInterface::class);
+
+        return new UrlGenerator($routes);
     }
 }

src/ServiceFactory/Logger/LoggerFactory.php

@@ -7,6 +7,7 @@
 use Monolog\Formatter\LogstashFormatter;
 use Monolog\Handler\BufferHandler;
 use Monolog\Handler\StreamHandler;
+use Monolog\Level;
 use Monolog\Logger;
 use Psr\Container\ContainerInterface;
 use Psr\Log\LoggerInterface;
@@ -15,13 +16,16 @@ final class LoggerFactory
 {
     public function __invoke(ContainerInterface $container): LoggerInterface
     {
-        $config = $container->get('config')['monolog'];
+        /** @var array{monolog: array{name: string, path: string, level: Level}} $config */
+        $config = $container->get('config');
 
-        return new Logger($config['name'], [
+        $monologConfig = $config['monolog'];
+
+        return new Logger($monologConfig['name'], [
             new BufferHandler(
                 (new StreamHandler(
-                    $config['path'],
-                    $config['level']
+                    $monologConfig['path'],
+                    $monologConfig['level']
                 ))->setFormatter(new LogstashFormatter('app'))
             ),
         ]);

src/ServiceFactory/RequestHandler/PingRequestHandlerFactory.php

@@ -12,6 +12,9 @@ final class PingRequestHandlerFactory
 {
     public function __invoke(ContainerInterface $container): PingRequestHandler
     {
-        return new PingRequestHandler($container->get(ResponseFactoryInterface::class));
+        /** @var ResponseFactoryInterface $responseFactory */
+        $responseFactory = $container->get(ResponseFactoryInterface::class);
+
+        return new PingRequestHandler($responseFactory);
     }
 }

src/console.php

@@ -24,5 +24,9 @@
 $console->getDefinition()->addOption(
     new InputOption('--env', '-e', InputOption::VALUE_REQUIRED, 'The Environment name.', 'dev')
 );
-$console->addCommands($container->get(Command::class.'[]'));
+
+/** @var array<Command> $commands */
+$commands = $container->get(Command::class.'[]');
+
+$console->addCommands($commands);
 $console->run($input);

src/web.php

@@ -14,5 +14,8 @@
     /** @var ContainerInterface $container */
     $container = (require __DIR__.'/container.php')($env);
 
-    return new Application($container->get(MiddlewareInterface::class.'[]'));
+    /** @var array<MiddlewareInterface> $middlewares */
+    $middlewares = $container->get(MiddlewareInterface::class.'[]');
+
+    return new Application($middlewares);
 };