Skip to content

Commit 18d4fbc

Browse files
SupernaviXbfops
andauthored
Upgrade prometheus to 0.14.0 (#4598)
# Description of Changes Upgrades the rust SDK's prometheus dependency from 0.13 to 0.14. Fixes #4597 # API and ABI breaking changes [The prometheus changelog](https://github.com/tikv/rust-prometheus/blob/master/CHANGELOG.md#0140) claims that the MSRV for the new version is 1.82, but this project doesn't seem to have an official MSRV, so I don't think that's an ABI change. I don't think depending on a different prometheus version is itself a breaking change. Prometheus is exposed through the rust SDK, but in an explicitly [unstable module](https://github.com/clockworklabs/SpacetimeDB/blob/3f58b5951bf3c49971c51aecb526439597b9c044/sdks/rust/src/lib.rs#L69-L76) which "may change incompatibly without a major version bump". Prometheus structs are also exposed from several crates, but with the same disclaimers about unstable interfaces. # Expected complexity level and risk 1. This is a module bump with simple-looking changes. # Testing - [x] Just confirmed everything still compiles and the tests still pass Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
1 parent 534fd30 commit 18d4fbc

3 files changed

Lines changed: 21 additions & 7 deletions

File tree

Cargo.lock

Lines changed: 19 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ pgwire = { version = "0.34.2", default-features = false, features = ["server-api
249249
postgres-types = "0.2.5"
250250
pretty_assertions = { version = "1.4", features = ["unstable"] }
251251
proc-macro2 = "1.0"
252-
prometheus = "0.13.0"
252+
prometheus = "0.14.0"
253253
proptest = "1.4"
254254
proptest-derive = "0.5"
255255
quick-junit = { version = "0.3.2" }

crates/client-api/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ serde = "1.0.136"
2323
serde_json = { version = "1.0", features = ["raw_value"] }
2424
anyhow = { version = "1.0.57", features = ["backtrace"] }
2525
regex = "1"
26-
prometheus = "0.13.0"
26+
prometheus.workspace = true
2727
email_address = "0.2.3"
2828
tempfile.workspace = true
2929
async-trait = "0.1.60"

0 commit comments

Comments
 (0)