CI - Move the git diff check under cargo ci smoketests (#4854)

# Description of Changes

To make `cargo ci` more properly the full test logic.

# API and ABI breaking changes

<!-- If this is an API or ABI breaking change, please apply the
corresponding GitHub label. -->

# Expected complexity level and risk

1

# Testing

honestly none

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>

Author: bfops

.github/workflows/ci.yml

@@ -171,13 +171,6 @@ jobs:
           }
           cargo ci smoketests -- --test-threads=1          
 
-      - name: Check for changes
-        run: |
-          tools/check-diff.sh crates/smoketests || {
-              echo 'Error: There is a diff in the smoketests directory.'
-              exit 1
-          }
-
   test:
     needs: [lints]
     name: Test Suite

tools/ci/src/main.rs

@@ -535,6 +535,7 @@ fn main() -> Result<()> {
         }
 
         Some(CiCmd::Smoketests(args)) => {
+            ensure_repo_root()?;
             smoketest::run(args)?;
         }
 

tools/ci/src/smoketest.rs

@@ -179,6 +179,11 @@ fn run_smoketest(server: Option<String>, dotnet: bool, args: Vec<String>) -> Res
     let status = cmd.args(&args).status()?;
 
     ensure!(status.success(), "Tests failed");
+    let diff_status = cmd!("bash", "tools/check-diff.sh", "crates/smoketests").run()?;
+    ensure!(
+        diff_status.status.success(),
+        "There is a diff in the smoketests directory."
+    );
     Ok(())
 }