Skip to content

Commit 30cc7e0

Browse files
Make confirmed reads the default for the ts connector (#4682)
# Description of Changes Make confirmed reads the default for the typescript benchmark client. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing N/A
1 parent e22807c commit 30cc7e0

6 files changed

Lines changed: 17 additions & 1 deletion

File tree

templates/keynote-2/.env.example

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ STDB_URL=ws://127.0.0.1:3000
2727
STDB_MODULE=test-1
2828
STDB_MODULE_PATH=./spacetimedb
2929
STDB_METRICS_URL=http://127.0.0.1:3000/v1/metrics
30+
STDB_CONFIRMED_READS=1
3031

3132
# ===== Supabase =====
3233
# Replace with your actual Supabase project ref

templates/keynote-2/DEVELOP.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ Copy `.env.example` to `.env` and adjust.
8888
- `STDB_MODULE` – module name to load (e.g. `test-1`)
8989
- `STDB_MODULE_PATH` – filesystem path to the module source (for local dev)
9090
- `STDB_METRICS_URL` – HTTP URL for the SpacetimeDB metrics endpoint
91+
- `STDB_CONFIRMED_READS``1` = force confirmed reads on, `0` = force them off
9192

9293
**Supabase:**
9394

templates/keynote-2/docker-compose-linux-raid-crdb.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,7 @@
175175
STDB_MODULE: ${STDB_MODULE}
176176
STDB_MODULE_PATH: ${STDB_MODULE_PATH}
177177
STDB_METRICS_URL: ${STDB_METRICS_URL}
178+
STDB_CONFIRMED_READS: ${STDB_CONFIRMED_READS}
178179
BUN_URL: ${BUN_URL}
179180
SQLITE_FILE: /data/accounts.sqlite
180181
SQLITE_MODE: ${SQLITE_MODE}

templates/keynote-2/docker-compose-linux-raid.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@
293293
STDB_MODULE: ${STDB_MODULE}
294294
STDB_MODULE_PATH: ${STDB_MODULE_PATH}
295295
STDB_METRICS_URL: ${STDB_METRICS_URL}
296+
STDB_CONFIRMED_READS: ${STDB_CONFIRMED_READS}
296297
BUN_URL: ${BUN_URL}
297298
SQLITE_FILE: /data/accounts.sqlite
298299
SQLITE_MODE: ${SQLITE_MODE}

templates/keynote-2/docker-compose.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@
258258
STDB_MODULE: ${STDB_MODULE}
259259
STDB_MODULE_PATH: ${STDB_MODULE_PATH}
260260
STDB_METRICS_URL: ${STDB_METRICS_URL}
261+
STDB_CONFIRMED_READS: ${STDB_CONFIRMED_READS}
261262
BUN_URL: ${BUN_URL}
262263
SQLITE_FILE: ${SQLITE_FILE}
263264
SQLITE_MODE: ${SQLITE_MODE}

templates/keynote-2/src/connectors/spacetimedb.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
11
import type { ReducerConnector } from '../core/connectors';
22
import * as mod from '../../module_bindings';
33

4+
function useConfirmedReads(): boolean {
5+
switch (process.env.STDB_CONFIRMED_READS) {
6+
case '0':
7+
return false;
8+
case '1':
9+
return true;
10+
default:
11+
return true;
12+
}
13+
}
14+
415
export function spacetimedb(
516
url = process.env.STDB_URL!,
617
moduleName = process.env.STDB_MODULE!,
@@ -35,7 +46,7 @@ export function spacetimedb(
3546
const builder = Db.builder()
3647
.withUri(url)
3748
.withDatabaseName(moduleName)
38-
.withConfirmedReads(process.env.STDB_CONFIRMED_READS === '1')
49+
.withConfirmedReads(useConfirmedReads())
3950
.onConnect((ctx) => {
4051
console.log('[stdb] connected');
4152
const conn = ctx;

0 commit comments

Comments
 (0)