Commit 6b1db9a
Include full error chain in procedure HTTP request errors (#4610)
Summary
When an HTTP request fails inside a procedure, the error message only
shows something like "error sending request for url (https://...)" with
no details about what actually went wrong.
This change walks the full error chain so the message includes the root
cause — things like DNS failures, connection refused, timeouts, etc.
- Before: error sending request for url (https://httpbin.org/get)
- After: error sending request for url (https://httpbin.org/get): error
trying to connect: dns error: failed to lookup address information:
Fixes #4608
Test plan
- Trigger an HTTP failure in a procedure and check that the error
message now shows the actual reason for the failure
- Existing tests should still pass since this only changes error
formatting
Co-authored-by: Phoebe Goldman <phoebe@clockworklabs.io>1 parent f8d6d76 commit 6b1db9a
1 file changed
Lines changed: 13 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
857 | 857 | | |
858 | 858 | | |
859 | 859 | | |
860 | | - | |
861 | | - | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
862 | 872 | | |
863 | 873 | | |
864 | 874 | | |
| |||
888 | 898 | | |
889 | 899 | | |
890 | 900 | | |
891 | | - | |
| 901 | + | |
892 | 902 | | |
893 | 903 | | |
894 | 904 | | |
| |||
0 commit comments