CI - rustfmt instead of cargo fmt (#4595)

# Description of Changes

`cargo ci lint` was running `cargo fmt`, but that didn't pick up all
files. As a result, our pre-commit hook (which just runs `rustfmt` on
any changed `.rs` files) would change otherwise-untouched files in merge
commits.

This PR addresses that discrepancy by having `cargo ci lint` run
`rustfmt` on all tracked `.rs` files.

The entire diff is just `rustfmt` changes except for the changes in
`tools/ci/src/main.rs`.

# API and ABI breaking changes

<!-- If this is an API or ABI breaking change, please apply the
corresponding GitHub label. -->

# Expected complexity level and risk

2

# Testing

- [x] `cargo ci lint` fails
- [x] `cargo ci lint` passes after running `rustfmt` on everything
- [x] `cargo fmt --all` doesn't cause any diff after doing the above

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>

Author: bfops

crates/bindings/tests/ui/views.rs

@@ -144,7 +144,6 @@ fn sched_table_view(_: &ViewContext, _args: ScheduledTable) -> Vec<PlayerInfo> {
     vec![]
 }
 
-
 #[table(accessor = player_info)]
 struct PlayerInfo {
     #[unique]

crates/bindings/tests/ui/views.stderr

@@ -61,20 +61,20 @@ error[E0425]: cannot find type `ScheduledTable` in this scope
     |                                             ^^^^^^^^^^^^^^ not found in this scope
 
 error[E0425]: cannot find type `T` in this scope
-   --> tests/ui/views.rs:202:60
+   --> tests/ui/views.rs:201:60
     |
-202 | fn view_nonexistent_table(ctx: &ViewContext) -> impl Query<T> {
+201 | fn view_nonexistent_table(ctx: &ViewContext) -> impl Query<T> {
     |                                                            ^ not found in this scope
     |
 help: you might be missing a type parameter
     |
-202 | fn view_nonexistent_table<T>(ctx: &ViewContext) -> impl Query<T> {
+201 | fn view_nonexistent_table<T>(ctx: &ViewContext) -> impl Query<T> {
     |                          +++
 
 error[E0425]: cannot find type `T` in this scope
-   --> tests/ui/views.rs:202:60
+   --> tests/ui/views.rs:201:60
     |
-202 | fn view_nonexistent_table(ctx: &ViewContext) -> impl Query<T> {
+201 | fn view_nonexistent_table(ctx: &ViewContext) -> impl Query<T> {
     |                                                            ^ not found in this scope
 
 error[E0277]: the trait bound `ViewKind<ReducerContext>: ViewKindTrait` is not satisfied
@@ -411,9 +411,9 @@ help: the trait `SpacetimeType` is not implemented for `NotSpacetimeType`
     = note: required for `Option<NotSpacetimeType>` to implement `SpacetimeType`
 
 error[E0277]: the trait bound `{integer}: RHS<Player, spacetimedb::Identity>` is not satisfied
-   --> tests/ui/views.rs:160:49
+   --> tests/ui/views.rs:159:49
     |
-160 |     ctx.from.player().r#where(|a| a.identity.eq(42)).build()
+159 |     ctx.from.player().r#where(|a| a.identity.eq(42)).build()
     |                                              -- ^^ the trait `RHS<Player, spacetimedb::Identity>` is not implemented for `{integer}`
     |                                              |
     |                                              required by a bound introduced by this call
@@ -435,9 +435,9 @@ note: required by a bound in `Col::<T, V>::eq`
     |                  ^^^^^^^^^ required by this bound in `Col::<T, V>::eq`
 
 error[E0277]: the trait bound `u32: RHS<PlayerInfo, u8>` is not satisfied
-   --> tests/ui/views.rs:166:49
+   --> tests/ui/views.rs:165:49
     |
-166 |     ctx.from.player_info().r#where(|a| a.age.eq(4200u32)).build()
+165 |     ctx.from.player_info().r#where(|a| a.age.eq(4200u32)).build()
     |                                              -- ^^^^^^^ the trait `RHS<PlayerInfo, u8>` is not implemented for `u32`
     |                                              |
     |                                              required by a bound introduced by this call
@@ -457,9 +457,9 @@ note: required by a bound in `Col::<T, V>::eq`
     = note: this error originates in the macro `impl_rhs` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error[E0308]: mismatched types
-   --> tests/ui/views.rs:175:62
+   --> tests/ui/views.rs:174:62
     |
-175 |         .left_semijoin(ctx.from.player(), |a, b| a.weight.eq(b.identity))
+174 |         .left_semijoin(ctx.from.player(), |a, b| a.weight.eq(b.identity))
     |                                                           -- ^^^^^^^^^^ expected `IxCol<Player, u32>`, found `IxCol<Player, Identity>`
     |                                                           |
     |                                                           arguments to this method are incorrect
@@ -473,15 +473,15 @@ note: method defined here
     |            ^^
 
 error[E0609]: no field `age` on type `&PlayerInfoIxCols`
-   --> tests/ui/views.rs:185:72
+   --> tests/ui/views.rs:184:72
     |
-185 |         .right_semijoin(ctx.from.player_info(), |a, b| a.identity.eq(b.age))
+184 |         .right_semijoin(ctx.from.player_info(), |a, b| a.identity.eq(b.age))
     |                                                                        ^^^ unknown field
     |
     = note: available fields are: `identity`, `weight`
 
 error[E0599]: no method named `xyz` found for struct `QueryBuilder` in the current scope
-   --> tests/ui/views.rs:203:14
+   --> tests/ui/views.rs:202:14
     |
-203 |     ctx.from.xyz().build()
+202 |     ctx.from.xyz().build()
     |              ^^^ method not found in `QueryBuilder`

crates/smoketests/modules/add-remove-index-indexed/src/lib.rs

@@ -1,10 +1,16 @@
 use spacetimedb::{ReducerContext, Table};
 
 #[spacetimedb::table(accessor = t1)]
-pub struct T1 { #[index(btree)] id: u64 }
+pub struct T1 {
+    #[index(btree)]
+    id: u64,
+}
 
 #[spacetimedb::table(accessor = t2)]
-pub struct T2 { #[index(btree)] id: u64 }
+pub struct T2 {
+    #[index(btree)]
+    id: u64,
+}
 
 #[spacetimedb::reducer(init)]
 pub fn init(ctx: &ReducerContext) {

crates/smoketests/modules/add-remove-index/src/lib.rs

@@ -1,10 +1,14 @@
 use spacetimedb::{ReducerContext, Table};
 
 #[spacetimedb::table(accessor = t1)]
-pub struct T1 { id: u64 }
+pub struct T1 {
+    id: u64,
+}
 
 #[spacetimedb::table(accessor = t2)]
-pub struct T2 { id: u64 }
+pub struct T2 {
+    id: u64,
+}
 
 #[spacetimedb::reducer(init)]
 pub fn init(ctx: &ReducerContext) {

crates/smoketests/modules/call-reducer-procedure/src/lib.rs

@@ -12,5 +12,7 @@ pub fn say_hello(_ctx: &ReducerContext) {
 
 #[spacetimedb::procedure]
 pub fn return_person(_ctx: &mut ProcedureContext) -> Person {
-   return Person { name: "World".to_owned() };
+    return Person {
+        name: "World".to_owned(),
+    };
 }

crates/smoketests/modules/delete-database/src/lib.rs

@@ -1,10 +1,10 @@
-use spacetimedb::{ReducerContext, Table, duration};
+use spacetimedb::{duration, ReducerContext, Table};
 
 #[spacetimedb::table(accessor = counter, public)]
 pub struct Counter {
     #[primary_key]
     id: u64,
-    val: u64
+    val: u64,
 }
 
 #[spacetimedb::table(accessor = scheduled_counter, public, scheduled(inc, at = sched_at))]

crates/smoketests/modules/filtering/src/lib.rs

@@ -13,16 +13,24 @@ pub struct Person {
 
 #[spacetimedb::reducer]
 pub fn insert_person(ctx: &ReducerContext, id: i32, name: String, nick: String) {
-    ctx.db.person().insert(Person { id, name, nick} );
+    ctx.db.person().insert(Person { id, name, nick });
 }
 
 #[spacetimedb::reducer]
 pub fn insert_person_twice(ctx: &ReducerContext, id: i32, name: String, nick: String) {
     // We'd like to avoid an error due to a set-semantic error.
     let name2 = format!("{name}2");
-    ctx.db.person().insert(Person { id, name, nick: nick.clone()} );
-    match ctx.db.person().try_insert(Person { id, name: name2, nick: nick.clone()}) {
-        Ok(_) => {},
+    ctx.db.person().insert(Person {
+        id,
+        name,
+        nick: nick.clone(),
+    });
+    match ctx.db.person().try_insert(Person {
+        id,
+        name: name2,
+        nick: nick.clone(),
+    }) {
+        Ok(_) => {}
         Err(_) => {
             log::info!("UNIQUE CONSTRAINT VIOLATION ERROR: id = {}, nick = {}", id, nick)
         }
@@ -85,7 +93,7 @@ pub struct NonuniquePerson {
 
 #[spacetimedb::reducer]
 pub fn insert_nonunique_person(ctx: &ReducerContext, id: i32, name: String, is_human: bool) {
-    ctx.db.nonunique_person().insert(NonuniquePerson { id, name, is_human } );
+    ctx.db.nonunique_person().insert(NonuniquePerson { id, name, is_human });
 }
 
 #[spacetimedb::reducer]
@@ -158,7 +166,11 @@ struct IndexedPerson {
 
 #[spacetimedb::reducer]
 fn insert_indexed_person(ctx: &ReducerContext, id: i32, given_name: String, surname: String) {
-    ctx.db.indexed_person().insert(IndexedPerson { id, given_name, surname });
+    ctx.db.indexed_person().insert(IndexedPerson {
+        id,
+        given_name,
+        surname,
+    });
 }
 
 #[spacetimedb::reducer]
@@ -169,14 +181,24 @@ fn delete_indexed_person(ctx: &ReducerContext, id: i32) {
 #[spacetimedb::reducer]
 fn find_indexed_people(ctx: &ReducerContext, surname: String) {
     for person in ctx.db.indexed_person().surname().filter(&surname) {
-        log::info!("INDEXED FOUND: id {}: {}, {}", person.id, person.surname, person.given_name);
+        log::info!(
+            "INDEXED FOUND: id {}: {}, {}",
+            person.id,
+            person.surname,
+            person.given_name
+        );
     }
 }
 
 #[spacetimedb::reducer]
 fn find_indexed_people_read_only(ctx: &ReducerContext, surname: String) {
     let ctx = ctx.as_read_only();
     for person in ctx.db.indexed_person().surname().filter(&surname) {
-        log::info!("INDEXED FOUND: id {}: {}, {}", person.id, person.surname, person.given_name);
+        log::info!(
+            "INDEXED FOUND: id {}: {}, {}",
+            person.id,
+            person.surname,
+            person.given_name
+        );
     }
 }

crates/smoketests/modules/module-nested-op/src/lib.rs

@@ -15,15 +15,18 @@ pub struct Friends {
 
 #[spacetimedb::reducer]
 pub fn create_account(ctx: &ReducerContext, account_id: i32, name: String) {
-    ctx.db.account().insert(Account { id: account_id, name } );
+    ctx.db.account().insert(Account { id: account_id, name });
 }
 
 #[spacetimedb::reducer]
 pub fn add_friend(ctx: &ReducerContext, my_id: i32, their_id: i32) {
     // Make sure our friend exists
     for account in ctx.db.account().iter() {
         if account.id == their_id {
-            ctx.db.friends().insert(Friends { friend_1: my_id, friend_2: their_id });
+            ctx.db.friends().insert(Friends {
+                friend_1: my_id,
+                friend_2: their_id,
+            });
             return;
         }
     }

crates/smoketests/modules/new-user-flow/src/lib.rs

@@ -2,7 +2,7 @@ use spacetimedb::{log, ReducerContext, Table};
 
 #[spacetimedb::table(accessor = person)]
 pub struct Person {
-    name: String
+    name: String,
 }
 
 #[spacetimedb::reducer]

crates/smoketests/modules/pg-wire/src/lib.rs

@@ -1,5 +1,5 @@
 use spacetimedb::sats::{i256, u256};
-use spacetimedb::{ConnectionId, Identity, ReducerContext, SpacetimeType, Table, Timestamp, TimeDuration, Uuid};
+use spacetimedb::{ConnectionId, Identity, ReducerContext, SpacetimeType, Table, TimeDuration, Timestamp, Uuid};
 
 #[derive(Copy, Clone)]
 #[spacetimedb::table(accessor = t_ints, public)]
@@ -50,7 +50,7 @@ pub struct TOthers {
 
 #[spacetimedb::table(accessor = t_others_tuple, public)]
 pub struct TOthersTuple {
-    tuple: TOthers
+    tuple: TOthers,
 }
 
 #[derive(SpacetimeType, Debug, Clone, Copy)]
@@ -79,9 +79,9 @@ pub struct TEnum {
 
 #[spacetimedb::table(accessor = t_nested, public)]
 pub struct TNested {
-   en: TEnum,
-   se: TSimpleEnum,
-   ints: TInts,
+    en: TEnum,
+    se: TSimpleEnum,
+    ints: TInts,
 }
 
 #[derive(Clone)]
@@ -127,7 +127,7 @@ pub fn test(ctx: &ReducerContext) {
         f32: 594806.58906,
         f64: -3454353.345389043278459,
         str: "This is spacetimedb".to_string(),
-        bytes: vec!(1, 2, 3, 4, 5, 6, 7),
+        bytes: vec![1, 2, 3, 4, 5, 6, 7],
         identity: Identity::ONE,
         connection_id: ConnectionId::ZERO,
         timestamp: Timestamp::UNIX_EPOCH,
@@ -137,14 +137,29 @@ pub fn test(ctx: &ReducerContext) {
     ctx.db.t_others().insert(tuple.clone());
     ctx.db.t_others_tuple().insert(TOthersTuple { tuple });
 
-    ctx.db.t_simple_enum().insert(TSimpleEnum { id: 1, action: Action::Inactive });
-    ctx.db.t_simple_enum().insert(TSimpleEnum { id: 2, action: Action::Active });
+    ctx.db.t_simple_enum().insert(TSimpleEnum {
+        id: 1,
+        action: Action::Inactive,
+    });
+    ctx.db.t_simple_enum().insert(TSimpleEnum {
+        id: 2,
+        action: Action::Active,
+    });
 
-    ctx.db.t_enum().insert(TEnum { id: 1, color: Color::Gray(128) });
+    ctx.db.t_enum().insert(TEnum {
+        id: 1,
+        color: Color::Gray(128),
+    });
 
     ctx.db.t_nested().insert(TNested {
-        en: TEnum { id: 1, color: Color::Gray(128) },
-        se: TSimpleEnum { id: 2, action: Action::Active },
+        en: TEnum {
+            id: 1,
+            color: Color::Gray(128),
+        },
+        se: TSimpleEnum {
+            id: 2,
+            action: Action::Active,
+        },
         ints,
     });