[TS] Export reducers, etc from a module (#4220)

# Description of Changes

Haven't changed `schema()` to accept an object yet, maybe that's for a
followup?

Now everything exported from the module must be exported from the
typescript module.

# Expected complexity level and risk

<!--
How complicated do you think these changes are? Grade on a scale from 1
to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex
change.

This complexity rating applies not only to the complexity apparent in
the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning
ways. -->

# Testing

<!-- Describe any testing you've done, and any testing you'd like your
reviewers to do,
so that you're confident that all the changes work as expected! -->

- [ ] <!-- maybe a test you want to do -->
- [ ] <!-- maybe a test you want a reviewer to do, so they can check it
off when they're satisfied. -->

Author: coolreader18

Cargo.lock

@@ -255,6 +255,7 @@ rayon-core = "1.11.0"
 regex = "1"
 reqwest = { version = "0.12", features = ["stream", "json"] }
 rolldown = { git = "https://github.com/rolldown/rolldown.git", tag = "v1.0.0-beta.42" }
+rolldown_common = { git = "https://github.com/rolldown/rolldown.git", tag = "v1.0.0-beta.42" }
 rolldown_utils = { git = "https://github.com/rolldown/rolldown.git", tag = "v1.0.0-beta.42" }
 ron = "0.8"
 rusqlite = { version = "0.29.0", features = ["bundled", "column_decltype"] }

Cargo.toml

@@ -20,8 +20,7 @@
   "author": "Clockwork Labs",
   "type": "module",
   "sideEffects": [
-    "./src/server/polyfills.ts",
-    "./src/server/register_hooks.ts"
+    "./src/server/polyfills.ts"
   ],
   "scripts": {
     "build:js": "tsup",

crates/bindings-typescript/package.json

@@ -41,15 +41,20 @@ type ColList = ColId[];
 /**
  * Check if any column in the row has invalid metadata.
  */
-type HasInvalidColumn<Row extends RowObj> = {
-  [K in keyof Row]: Row[K] extends ColumnBuilder<any, any, infer M>
-    ? ValidateColumnMetadata<M> extends InvalidColumnMetadata<any>
-      ? true
-      : false
-    : false;
-}[keyof Row] extends false
-  ? false
-  : true;
+type HasInvalidColumn<Row extends RowObj> =
+  // this checks if Row exactly equals RowObj - if it does, we can't
+  // do type-system-level checking, so just let it pass
+  (<G>() => G extends Row ? 1 : 2) extends <G>() => G extends RowObj ? 1 : 2
+    ? false
+    : {
+          [K in keyof Row]: Row[K] extends ColumnBuilder<any, any, infer M>
+            ? ValidateColumnMetadata<M> extends InvalidColumnMetadata<any>
+              ? true
+              : false
+            : false;
+        }[keyof Row] extends false
+      ? false
+      : true;
 
 /**
  * Extract the names of columns that have invalid metadata.

crates/bindings-typescript/src/lib/autogen/function_visibility_type.ts

@@ -1,14 +1,19 @@
 export * from '../lib/type_builders';
-export { schema, type InferSchema } from './schema';
+export { schema, type InferSchema, type ModuleExport } from './schema';
 export { table } from '../lib/table';
 export { SenderError, SpacetimeHostError, errors } from './errors';
-export { type Reducer, type ReducerCtx } from '../lib/reducers';
+export type { Reducer, ReducerCtx } from '../lib/reducers';
+export type { ReducerExport } from './reducers';
 export { type DbView } from './db_view';
 export * from './query';
-export type { ProcedureCtx, TransactionCtx } from './procedures';
+export type {
+  ProcedureCtx,
+  TransactionCtx,
+  ProcedureExport,
+} from './procedures';
 export { toCamelCase } from '../lib/util';
-export { type Uuid } from '../lib/uuid';
-export { type Random } from './rng';
+export type { Uuid } from '../lib/uuid';
+export type { Random } from './rng';
+export type { ViewExport, ViewCtx, AnonymousViewCtx } from './views';
 
 import './polyfills'; // Ensure polyfills are loaded
-import './register_hooks'; // Ensure module hooks are registered

crates/bindings-typescript/src/lib/table.ts

@@ -20,16 +20,55 @@ import {
 import { bsatnBaseSize } from '../lib/util';
 import { Uuid } from '../lib/uuid';
 import { httpClient, type HttpClient } from './http_internal';
+import type { DbView } from './db_view';
 import { makeRandom, type Random } from './rng';
 import { callUserFunction, ReducerCtxImpl, sys } from './runtime';
-import type { SchemaInner } from './schema';
+import {
+  exportContext,
+  registerExport,
+  type ModuleExport,
+  type SchemaInner,
+} from './schema';
+
+export type ProcedureExport<
+  S extends UntypedSchemaDef,
+  Params extends ParamsObj,
+  Ret extends TypeBuilder<any, any>,
+> = ProcedureFn<S, Params, Ret> & ModuleExport;
+
+export function makeProcedureExport<
+  S extends UntypedSchemaDef,
+  Params extends ParamsObj,
+  Ret extends TypeBuilder<any, any>,
+>(
+  ctx: SchemaInner,
+  opts: ProcedureOpts | undefined,
+  params: Params,
+  ret: Ret,
+  fn: ProcedureFn<S, Params, Ret>
+): ProcedureExport<S, Params, Ret> {
+  const name = opts?.name;
+
+  const procedureExport: ProcedureExport<S, Params, Ret> = (...args) =>
+    fn(...args);
+  procedureExport[exportContext] = ctx;
+  procedureExport[registerExport] = (ctx, exportName) => {
+    registerProcedure(ctx, name ?? exportName, params, ret, fn);
+  };
+
+  return procedureExport;
+}
 
 export type ProcedureFn<
   S extends UntypedSchemaDef,
   Params extends ParamsObj,
   Ret extends TypeBuilder<any, any>,
 > = (ctx: ProcedureCtx<S>, args: InferTypeOfRow<Params>) => Infer<Ret>;
 
+export interface ProcedureOpts {
+  name: string;
+}
+
 export interface ProcedureCtx<S extends UntypedSchemaDef> {
   readonly sender: Identity;
   readonly identity: Identity;
@@ -46,7 +85,7 @@ export interface ProcedureCtx<S extends UntypedSchemaDef> {
 export interface TransactionCtx<S extends UntypedSchemaDef>
   extends ReducerCtx<S> {}
 
-export function procedure<
+function registerProcedure<
   S extends UntypedSchemaDef,
   Params extends ParamsObj,
   Ret extends TypeBuilder<any, any>,
@@ -98,7 +137,8 @@ export function callProcedure(
   sender: Identity,
   connectionId: ConnectionId | null,
   timestamp: Timestamp,
-  argsBuf: Uint8Array
+  argsBuf: Uint8Array,
+  dbView: () => DbView<any>
 ): Uint8Array {
   const { fn, deserializeArgs, serializeReturn, returnTypeBaseSize } =
     moduleCtx.procedures[id];
@@ -107,7 +147,8 @@ export function callProcedure(
   const ctx: ProcedureCtx<UntypedSchemaDef> = new ProcedureCtxImpl(
     sender,
     timestamp,
-    connectionId
+    connectionId,
+    dbView
   );
 
   const ret = callUserFunction(fn, ctx, args);
@@ -123,12 +164,16 @@ const ProcedureCtxImpl = class ProcedureCtx<S extends UntypedSchemaDef>
   #identity: Identity | undefined;
   #uuidCounter: { value: 0 } | undefined;
   #random: Random | undefined;
+  #dbView: () => DbView<any>;
 
   constructor(
     readonly sender: Identity,
     readonly timestamp: Timestamp,
-    readonly connectionId: ConnectionId | null
-  ) {}
+    readonly connectionId: ConnectionId | null,
+    dbView: () => DbView<any>
+  ) {
+    this.#dbView = dbView;
+  }
 
   get identity() {
     return (this.#identity ??= new Identity(sys.identity()));
@@ -150,7 +195,8 @@ const ProcedureCtxImpl = class ProcedureCtx<S extends UntypedSchemaDef>
         const ctx: TransactionCtx<UntypedSchemaDef> = new ReducerCtxImpl(
           this.sender,
           new Timestamp(timestamp),
-          this.connectionId
+          this.connectionId,
+          this.#dbView()
         );
         return body(ctx);
       } catch (e) {