Move NativeAOT-LLVM for .NET 8 job to smoketest

Author: rekhoff

.github/workflows/ci.yml

@@ -893,42 +893,6 @@ jobs:
               exit 1
           }
 
-  # NativeAOT-LLVM smoketest runs on Windows because runtime.linux-x64.Microsoft.DotNet.ILCompiler.LLVM
-  # does not have 8.0.0 versions available on the dotnet-experimental NuGet feed.
-  csharp-aot-smoketest:
-    needs: [lints]
-    runs-on: windows-latest
-    timeout-minutes: 15
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Setup dotnet
-        uses: actions/setup-dotnet@v3
-        with:
-          global-json-file: global.json
-          
-      - name: Install emscripten (Windows)
-        shell: pwsh
-        run: |
-          git clone https://github.com/emscripten-core/emsdk.git $env:USERPROFILE\emsdk
-          cd $env:USERPROFILE\emsdk
-          .\emsdk install 4.0.21
-          .\emsdk activate 4.0.21
-
-      - name: Smoketest C# AOT build (NativeAOT-LLVM)
-        shell: pwsh
-        run: |
-          $env:EXPERIMENTAL_WASM_AOT = "1"
-          if (Test-Path "$env:USERPROFILE\emsdk\emsdk_env.ps1") {
-            & "$env:USERPROFILE\emsdk\emsdk_env.ps1" | Out-Null
-          }
-          dotnet publish -c Release modules/sdk-test-cs
-          if (-not (Test-Path "modules/sdk-test-cs/bin/Release/net8.0/wasi-wasm/publish/StdbModule.wasm")) {
-            Write-Error "StdbModule.wasm not found"
-            exit 1
-          }
-
   internal-tests:
     name: Internal Tests
     needs: [lints]

crates/smoketests/tests/smoketests/csharp_aot_module.rs

@@ -0,0 +1,50 @@
+#![allow(clippy::disallowed_macros)]
+use spacetimedb_guard::ensure_binaries_built;
+use spacetimedb_smoketests::{require_dotnet, workspace_root};
+use std::process::Command;
+
+/// Test NativeAOT-LLVM build path for C# modules.
+/// Requires emscripten to be installed.
+/// Only runs on Windows since runtime.linux-x64.Microsoft.DotNet.ILCompiler.LLVM
+/// is not available on the dotnet-experimental NuGet feed.
+#[test]
+fn test_build_csharp_module_aot() {
+    require_dotnet!();
+
+    // NativeAOT-LLVM is only available on Windows
+    if std::env::consts::OS != "windows" {
+        eprintln!("Skipping AOT test - NativeAOT-LLVM for .NET 8 only available on Windows");
+        return;
+    }
+
+    // Check for emscripten - skip if not available
+    let emscripten_check = Command::new("emcc").arg("--version").output();
+    if emscripten_check.is_err() || !emscripten_check.unwrap().status.success() {
+        eprintln!("Skipping AOT test - emscripten not available");
+        return;
+    }
+
+    let workspace = workspace_root();
+    let _cli_path = ensure_binaries_built();
+
+    // Set EXPERIMENTAL_WASM_AOT=1 for this specific build
+    // Build sdk-test-cs with NativeAOT-LLVM
+    let mut cmd = Command::new("dotnet");
+    cmd.arg("publish")
+        .arg("-c")
+        .arg("Release")
+        .current_dir(workspace.join("modules/sdk-test-cs"))
+        .env("EXPERIMENTAL_WASM_AOT", "1");
+
+    let output = cmd.output().expect("Failed to run dotnet publish");
+    assert!(
+        output.status.success(),
+        "NativeAOT-LLVM publish failed:\nstdout: {}\nstderr: {}",
+        String::from_utf8_lossy(&output.stdout),
+        String::from_utf8_lossy(&output.stderr)
+    );
+
+    // Verify StdbModule.wasm was produced
+    let wasm_path = workspace.join("modules/sdk-test-cs/bin/Release/net8.0/wasi-wasm/publish/StdbModule.wasm");
+    assert!(wasm_path.exists(), "StdbModule.wasm not found at {:?}", wasm_path);
+}

crates/smoketests/tests/smoketests/mod.rs

@@ -9,6 +9,7 @@ mod client_connection_errors;
 mod confirmed_reads;
 mod connect_disconnect_from_cli;
 mod create_project;
+mod csharp_aot_module;
 mod csharp_module;
 mod default_module_clippy;
 mod delete_database;