Remove __decribe_module_v10__ (#4246)

This reverts commit fd3cdb3.

# Description of Changes
Reverts #4105, We do not actually need `__describe_module_v10__`, as
original describe reducer returns `enum` - `crates:lib::RawModuleDef`
which is extended to add a variant for `V10`

# API and ABI breaking changes
NA
# Expected complexity level and risk
1
# Testing
Existing tests should be enough

Author: Shubham8287

crates/bindings-sys/src/lib.rs

@@ -924,7 +924,7 @@ pub mod raw {
             /// would be where you would initialize the interepreter and load the user module into it.
             fn __setup__() -> Result;
             /// Required. Runs after `__setup__`; returns all the exports for the module.
-            fn __describe_module_v10__() -> Encoded<ModuleDef>;
+            fn __describe_module__() -> Encoded<ModuleDef>;
             /// Required. id is an index into the `ModuleDef.reducers` returned from `__describe_module__`.
             /// args is a bsatn-encoded product value defined by the schema at `reducers[id]`.
             fn __call_reducer__(

crates/bindings/src/rt.rs

@@ -678,7 +678,7 @@ pub trait RowLevelSecurityInfo {
 }
 
 /// A function which will be registered by [`register_describer`] into [`DESCRIBERS`],
-/// which will be called by [`__describe_module_v10__`] to construct a module definition.
+/// which will be called by [`__describe_module__`] to construct a module definition.
 ///
 /// May be a closure over static data, so that e.g.
 /// [`register_row_level_security`] doesn't need to take a type parameter.
@@ -874,7 +874,7 @@ static ANONYMOUS_VIEWS: OnceLock<Vec<AnonymousFn>> = OnceLock::new();
 /// including when modules are updated (re-publishing).
 /// After initialization, the module cannot alter the schema.
 #[no_mangle]
-extern "C" fn __describe_module_v10__(description: BytesSink) {
+extern "C" fn __describe_module__(description: BytesSink) {
     // Collect the `module`.
     let mut module = ModuleBuilder::default();
     for describer in &mut *DESCRIBERS.lock().unwrap() {

crates/core/src/host/module_common.rs

@@ -3,7 +3,11 @@
 
 use crate::{
     energy::EnergyMonitor,
-    host::{module_host::ModuleInfo, wasm_common::module_host_actor::DescribeError, Scheduler},
+    host::{
+        module_host::ModuleInfo,
+        wasm_common::{module_host_actor::DescribeError, DESCRIBE_MODULE_DUNDER},
+        Scheduler,
+    },
     module_host_context::ModuleCreationContext,
     replica_context::ReplicaContext,
 };
@@ -86,10 +90,11 @@ impl ModuleCommon {
 
 /// Runs the describer of modules in `run` and does some logging around it.
 pub(crate) fn run_describer<T>(
-    describer_func_name: &str,
     log_traceback: impl Copy + FnOnce(&str, &str, &anyhow::Error),
     run: impl FnOnce() -> anyhow::Result<T>,
 ) -> Result<T, DescribeError> {
+    let describer_func_name = DESCRIBE_MODULE_DUNDER;
+
     let start = std::time::Instant::now();
     log::trace!("Start describer \"{describer_func_name}\"...");
 

crates/core/src/host/v8/mod.rs

@@ -25,7 +25,7 @@ use crate::host::wasm_common::module_host_actor::{
     InstanceOp, ProcedureExecuteResult, ProcedureOp, ReducerExecuteResult, ReducerOp, ViewExecuteResult, ViewOp,
     WasmInstance,
 };
-use crate::host::wasm_common::{RowIters, TimingSpanSet, DESCRIBE_MODULE_DUNDER};
+use crate::host::wasm_common::{RowIters, TimingSpanSet};
 use crate::host::{ModuleHost, ReducerCallError, ReducerCallResult, Scheduler};
 use crate::module_host_context::ModuleCreationContext;
 use crate::replica_context::ReplicaContext;
@@ -925,8 +925,6 @@ fn extract_description<'scope>(
     replica_ctx: &ReplicaContext,
 ) -> Result<RawModuleDef, DescribeError> {
     run_describer(
-        //TODO(shub): make it work with `DESCRIBE_MODULE_DUNDER_V10`
-        DESCRIBE_MODULE_DUNDER,
         |a, b, c| log_traceback(replica_ctx, a, b, c),
         || {
             catch_exception(scope, |scope| {

crates/core/src/host/wasm_common.rs

@@ -10,7 +10,6 @@ use super::{scheduler::ScheduleError, AbiCall};
 use crate::error::{DBError, DatastoreError, IndexError, NodesError};
 use spacetimedb_primitives::errno;
 use spacetimedb_sats::typespace::TypeRefError;
-use spacetimedb_schema::def::RawModuleDefVersion;
 use spacetimedb_table::table::UniqueConstraintViolation;
 
 pub const CALL_REDUCER_DUNDER: &str = "__call_reducer__";
@@ -21,52 +20,13 @@ pub const CALL_VIEW_DUNDER: &str = "__call_view__";
 
 pub const CALL_VIEW_ANON_DUNDER: &str = "__call_view_anon__";
 
-/// Name of the function that modules export to the host to describe themselves.
-///
-/// Used by module definitions with versions up to
-/// [`RawModuleDefVersion::V9OrEarlier`].
 pub const DESCRIBE_MODULE_DUNDER: &str = "__describe_module__";
 
-/// Versioned variant of [`DESCRIBE_MODULE_DUNDER`] for
-/// [`RawModuleDefVersion::V10`].
-pub const DESCRIBE_MODULE_DUNDER_V10: &str = "__describe_module_v10__";
-
 /// functions with this prefix run prior to __setup__, initializing global variables and the like
 pub const PREINIT_DUNDER: &str = "__preinit__";
 /// initializes the user code in the module. fallible
 pub const SETUP_DUNDER: &str = "__setup__";
 
-/// Detects the [`RawModuleDefVersion`] of a module by checking for the presence
-/// of a known describe function export.
-pub fn detect_raw_def_version<M>(module: &M) -> Result<RawModuleDefVersion, module_host_actor::DescribeError>
-where
-    M: module_host_actor::WasmModule,
-{
-    if module.get_export(DESCRIBE_MODULE_DUNDER).is_some() {
-        Ok(RawModuleDefVersion::V9OrEarlier)
-    } else if module.get_export(DESCRIBE_MODULE_DUNDER_V10).is_some() {
-        Ok(RawModuleDefVersion::V10)
-    } else {
-        Err(module_host_actor::DescribeError::Signature(anyhow::anyhow!(
-            "module does not export a {} or {} function",
-            DESCRIBE_MODULE_DUNDER,
-            DESCRIBE_MODULE_DUNDER_V10
-        )))
-    }
-}
-/// Returns the describe dunder symbol for a given module version.
-pub const fn describe_dunder(version: RawModuleDefVersion) -> &'static str {
-    match version {
-        RawModuleDefVersion::V9OrEarlier => DESCRIBE_MODULE_DUNDER,
-        RawModuleDefVersion::V10 => DESCRIBE_MODULE_DUNDER_V10,
-    }
-}
-
-/// Returns all known describe dunder symbols.
-pub const fn describe_dunders() -> &'static [&'static str] {
-    &[DESCRIBE_MODULE_DUNDER, DESCRIBE_MODULE_DUNDER_V10]
-}
-
 #[derive(Debug, Clone)]
 #[allow(unused)]
 pub enum WasmType {
@@ -269,7 +229,7 @@ impl FuncNames {
         }
         Ok(())
     }
-    pub fn check_required<F, T>(raw_def_ver: RawModuleDefVersion, get_export: F) -> Result<(), ValidationError>
+    pub fn check_required<F, T>(get_export: F) -> Result<(), ValidationError>
     where
         F: Fn(&str) -> Option<T>,
         T: FuncSigLike,
@@ -283,9 +243,8 @@ impl FuncNames {
         let sig = get_func(CALL_REDUCER_DUNDER)?;
         Self::validate_signature("call_reducer", &sig, CALL_REDUCER_DUNDER, CALL_REDUCER_SIG)?;
 
-        let describe_dunder = describe_dunder(raw_def_ver);
-        let sig = get_func(describe_dunder)?;
-        Self::validate_signature("describe_module", &sig, describe_dunder, DESCRIBE_MODULE_SIG)?;
+        let sig = get_func(DESCRIBE_MODULE_DUNDER)?;
+        Self::validate_signature("describe_module", &sig, DESCRIBE_MODULE_DUNDER, DESCRIBE_MODULE_SIG)?;
 
         Ok(())
     }

crates/core/src/host/wasm_common/module_host_actor.rs

@@ -283,7 +283,7 @@ impl From<TypeRefError> for InitializationError {
 
 #[derive(thiserror::Error, Debug)]
 pub enum DescribeError {
-    #[error("failed to call descriptor function: invalid signature or function does not exist: {0}")]
+    #[error("bad signature for descriptor function: {0}")]
     Signature(anyhow::Error),
     #[error("error when preparing descriptor function: {0}")]
     Setup(anyhow::Error),
@@ -304,9 +304,8 @@ impl<T: WasmModule> WasmModuleHostActor<T> {
             mcc.program_hash,
         );
 
-        let raw_def_version = detect_raw_def_version(&module)?;
         let func_names = {
-            FuncNames::check_required(raw_def_version, |name| module.get_export(name))?;
+            FuncNames::check_required(|name| module.get_export(name))?;
             let mut func_names = FuncNames::default();
             module.for_each_export(|sym, ty| func_names.update_from_general(sym, ty))?;
             func_names.preinits.sort_unstable();

crates/core/src/host/wasmtime/wasmtime_module.rs

@@ -352,27 +352,16 @@ pub struct WasmtimeInstance {
 
 impl module_host_actor::WasmInstance for WasmtimeInstance {
     fn extract_descriptions(&mut self) -> Result<RawModuleDef, DescribeError> {
-        let mut describer_res = None;
-        for &describe_func_name in describe_dunders() {
-            match self
-                .instance
-                .get_typed_func::<u32, ()>(&mut self.store, describe_func_name)
-            {
-                Ok(describer) => {
-                    describer_res = Some(Ok((describe_func_name, describer)));
-                    break;
-                }
-                Err(e) => describer_res = Some(Err(DescribeError::Signature(e))),
-            }
-        }
+        let describer_func_name = DESCRIBE_MODULE_DUNDER;
 
-        let (describer_func_name, describer) = describer_res
-            .transpose()?
-            .ok_or_else(|| DescribeError::Signature(anyhow::anyhow!("no describer function found")))?;
+        let describer = self
+            .instance
+            .get_typed_func::<u32, ()>(&mut self.store, describer_func_name)
+            .map_err(DescribeError::Signature)?;
 
         let sink = self.store.data_mut().setup_standard_bytes_sink();
 
-        run_describer(describer_func_name, log_traceback, || {
+        run_describer(log_traceback, || {
             call_sync_typed_func(&describer, &mut self.store, sink)
         })?;