lints

Shubham8287 · Shubham8287 · commit e0fb227ad228 · 2026-02-16T17:26:06.000+05:30
diff --git a/crates/bench/src/spacetime_raw.rs b/crates/bench/src/spacetime_raw.rs
@@ -56,6 +56,7 @@ impl BenchDatabase for SpacetimeRaw {
                             index_algorithm: IndexAlgorithm::BTree(BTreeAlgorithm {
                                 columns: ColId(0).into(),
                             }),
+                            alias: None,
                         },
                         true,
                     )?;
@@ -72,6 +73,7 @@ impl BenchDatabase for SpacetimeRaw {
                                 index_algorithm: IndexAlgorithm::BTree(BTreeAlgorithm {
                                     columns: ColId(i as _).into(),
                                 }),
+                                alias: None,
                             },
                             false,
                         )?;
diff --git a/crates/bindings-macro/src/table.rs b/crates/bindings-macro/src/table.rs
@@ -1,6 +1,6 @@
 use crate::sats;
 use crate::sym;
-use crate::util::{check_duplicate, check_duplicate_msg, ident_to_litstr, match_meta};
+use crate::util::{check_duplicate, check_duplicate_msg, match_meta};
 use core::slice;
 use heck::ToSnakeCase;
 use proc_macro2::{Span, TokenStream};
@@ -55,7 +55,7 @@ struct IndexArg {
 }
 
 impl IndexArg {
-    fn inline(accessor: Ident, kind: IndexType) -> Self {
+    fn new(accessor: Ident, kind: IndexType) -> Self {
         // We don't know if its unique yet.
         // We'll discover this once we have collected constraints.
         let is_unique = false;
@@ -66,14 +66,6 @@ impl IndexArg {
             //  name,
         }
     }
-    fn explicit(accessor: Ident, kind: IndexType) -> Self {
-        Self {
-            accessor,
-            is_unique: false,
-            kind,
-            // name: None,
-        }
-    }
 }
 
 enum IndexType {
@@ -214,7 +206,7 @@ impl IndexArg {
             )
         })?;
 
-        Ok(IndexArg::explicit(accessor, kind))
+        Ok(IndexArg::new(accessor, kind))
     }
 
     fn parse_columns(meta: &ParseNestedMeta) -> syn::Result<Option<Vec<Ident>>> {
@@ -305,7 +297,7 @@ impl IndexArg {
 
         // Default accessor = field name if not provided
         let accessor = field.clone();
-        Ok(IndexArg::inline(accessor, kind))
+        Ok(IndexArg::new(accessor, kind))
     }
 
     fn validate<'a>(&'a self, table_name: &str, cols: &'a [Column<'a>]) -> syn::Result<ValidatedIndex<'a>> {
diff --git a/crates/bindings-typescript/src/lib/table.ts b/crates/bindings-typescript/src/lib/table.ts
@@ -458,17 +458,17 @@ export function table<Row extends RowObj, const Opts extends TableOpts<Row>>(
         row.typeName = toPascalCase(tableName);
       }
 
-          // Build index source names using accName
-    for (const index of indexes) {
-      const cols =
-        index.algorithm.tag === 'Direct'
-          ? [index.algorithm.value]
-          : index.algorithm.value;
-
-      const colS = cols.map(i => colNameList[i]).join('_');
-      index.sourceName = `${accName}_${colS}_idx_${index.algorithm.tag.toLowerCase()}`;
-    }
-    
+      // Build index source names using accName
+      for (const index of indexes) {
+        const cols =
+          index.algorithm.tag === 'Direct'
+            ? [index.algorithm.value]
+            : index.algorithm.value;
+
+        const colS = cols.map(i => colNameList[i]).join('_');
+        index.sourceName = `${accName}_${colS}_idx_${index.algorithm.tag.toLowerCase()}`;
+      }
+
       return {
         sourceName: accName,
         productTypeRef: ctx.registerTypesRecursively(row).ref,
diff --git a/crates/bindings-typescript/src/server/schema.ts b/crates/bindings-typescript/src/server/schema.ts
@@ -541,14 +541,14 @@ export function schema<const H extends Record<string, UntypedTableSchema>>(
         });
       }
       if (table.tableName) {
-          ctx.moduleDef.explicitNames.entries.push ({
-            tag: "Table",
-            value: {
-              sourceName: accName,
-              canonicalName: table.tableName,
-            }
-          })
-        }
+        ctx.moduleDef.explicitNames.entries.push({
+          tag: 'Table',
+          value: {
+            sourceName: accName,
+            canonicalName: table.tableName,
+          },
+        });
+      }
     }
     return { tables: tableSchemas } as TablesToSchema<H>;
   });
diff --git a/crates/bindings-typescript/src/server/views.ts b/crates/bindings-typescript/src/server/views.ts
@@ -163,15 +163,15 @@ export function registerView<
     returnType,
   });
 
-  if (opts.name != null)  {
-  ctx.moduleDef.explicitNames.entries.push({
-    tag: "Function",
-    value: {
-      sourceName: exportName,
-      canonicalName: opts.name
-    }
-  })
-}
+  if (opts.name != null) {
+    ctx.moduleDef.explicitNames.entries.push({
+      tag: 'Function',
+      value: {
+        sourceName: exportName,
+        canonicalName: opts.name,
+      },
+    });
+  }
 
   // If it is an option, we wrap the function to make the return look like an array.
   if (returnType.tag == 'Sum') {
diff --git a/crates/core/src/db/relational_db.rs b/crates/core/src/db/relational_db.rs
@@ -1257,8 +1257,6 @@ impl RelationalDB {
             .map(|s| s.as_str())
             .unwrap_or(table_name);
 
-        println!("replaced table name {table_name} with {new_table}");
-
         Ok(self.inner.table_id_from_name_mut_tx(tx, new_table)?)
     }
 
@@ -1270,8 +1268,6 @@ impl RelationalDB {
             .map(|s| s.as_str())
             .unwrap_or(table_name);
 
-        println!("replaced table name {table_name} with {new_table}");
-
         Ok(self.inner.table_id_from_name_tx(tx, new_table)?)
     }
 
@@ -1303,8 +1299,6 @@ impl RelationalDB {
             .map(|s| s.as_str())
             .unwrap_or(index_name);
 
-        println!("replaced index name {index_name} with {new_index_name}");
-
         Ok(self.inner.index_id_from_name_mut_tx(tx, new_index_name)?)
     }
 
diff --git a/crates/datastore/src/locking_tx_datastore/datastore.rs b/crates/datastore/src/locking_tx_datastore/datastore.rs
@@ -1485,6 +1485,7 @@ mod tests {
                 col_pos: value.pos.into(),
                 col_name: Identifier::for_test(value.name),
                 col_type: value.ty,
+                alias: None,
             }
         }
     }
@@ -2108,6 +2109,7 @@ mod tests {
                 table_id,
                 index_name: "Foo_id_idx_btree".into(),
                 index_algorithm: BTreeAlgorithm::from(0).into(),
+                alias: None,
             },
             true,
         )?;
@@ -2349,6 +2351,7 @@ mod tests {
             table_id,
             index_name: "Foo_age_idx_btree".into(),
             index_algorithm: BTreeAlgorithm::from(2).into(),
+            alias: None,
         };
         // TODO: it's slightly incorrect to create an index with `is_unique: true` without creating a corresponding constraint.
         // But the `Table` crate allows it for now.
diff --git a/crates/physical-plan/src/plan.rs b/crates/physical-plan/src/plan.rs
@@ -1479,6 +1479,7 @@ mod tests {
                     col_name: Identifier::for_test(*name),
                     col_pos: i.into(),
                     col_type: ty.clone(),
+                    alias: None,
                 })
                 .collect(),
             indexes
@@ -1491,6 +1492,7 @@ mod tests {
                     index_algorithm: IndexAlgorithm::BTree(BTreeAlgorithm {
                         columns: ColList::from_iter(cols.iter().copied()),
                     }),
+                    alias: None,
                 })
                 .collect(),
             unique
@@ -1511,6 +1513,7 @@ mod tests {
             None,
             primary_key.map(ColId::from),
             false,
+            None,
         )))
     }
 
diff --git a/crates/schema/src/def/validate/v10.rs b/crates/schema/src/def/validate/v10.rs
@@ -345,7 +345,7 @@ impl<'a> ModuleValidatorV10<'a> {
             .into_iter()
             .map(|index| {
                 table_validator
-                    .validate_index_def_v10(index.into())
+                    .validate_index_def_v10(index)
                     .map(|index| (index.name.clone(), index))
             })
             .collect_all_errors::<StrMap<_>>();
@@ -403,7 +403,11 @@ impl<'a> ModuleValidatorV10<'a> {
             if table_type != TableType::System && name.starts_with("st_") {
                 Err(ValidationError::TableNameReserved { table: name }.into())
             } else {
-                let name = table_validator.add_to_global_namespace(name.as_raw().clone())?;
+                let mut name = name.as_raw().clone();
+                if name != raw_table_name {
+                    name = table_validator.add_to_global_namespace(name)?;
+                }
+
                 Ok(name)
             }
         };
@@ -524,7 +528,7 @@ impl<'a> ModuleValidatorV10<'a> {
         tables: &HashMap<Identifier, TableDef>,
     ) -> Result<(ScheduleDef, Identifier)> {
         let RawScheduleDefV10 {
-            source_name,
+            source_name: _,
             table_name,
             schedule_at_col,
             function_name,
@@ -671,7 +675,7 @@ impl<'a> ModuleValidatorV10<'a> {
             &return_type,
         );
 
-        let name_result = self.core.resolve_function_ident(accessor_name.clone());
+        let name = self.core.resolve_function_ident(accessor_name.clone())?;
 
         let mut view_validator = ViewValidator::new(
             accessor_name.clone(),
@@ -682,7 +686,7 @@ impl<'a> ModuleValidatorV10<'a> {
             &mut self.core,
         )?;
 
-        let name_result = view_validator.add_to_global_namespace(name_result?.as_raw().clone());
+        let _ = view_validator.add_to_global_namespace(name.as_raw().clone())?;
 
         let n = product_type.elements.len();
         let return_columns = (0..n)
@@ -694,11 +698,11 @@ impl<'a> ModuleValidatorV10<'a> {
             .map(|id| view_validator.validate_param_column_def(id.into()))
             .collect_all_errors();
 
-        let (name_result, return_type_for_generate, return_columns, param_columns) =
-            (name_result, return_type_for_generate, return_columns, param_columns).combine_errors()?;
+        let (return_type_for_generate, return_columns, param_columns) =
+            (return_type_for_generate, return_columns, param_columns).combine_errors()?;
 
         Ok(ViewDef {
-            name: self.core.resolve_function_ident(name_result.clone())?,
+            name,
             accessor_name: identifier(accessor_name)?,
             is_anonymous,
             is_public,
@@ -935,16 +939,19 @@ mod tests {
                     name: "Apples_count_idx_direct".into(),
                     codegen_name: Some(expect_identifier("Apples_count_idx_direct")),
                     algorithm: DirectAlgorithm { column: 2.into() }.into(),
+                    accessor_name: "Apples_count_idx_direct".into(),
                 },
                 &IndexDef {
                     name: "Apples_name_count_idx_btree".into(),
                     codegen_name: Some(expect_identifier("Apples_name_count_idx_btree")),
                     algorithm: BTreeAlgorithm { columns: [1, 2].into() }.into(),
+                    accessor_name: "Apples_name_count_idx_btree".into(),
                 },
                 &IndexDef {
                     name: "Apples_type_idx_btree".into(),
                     codegen_name: Some(expect_identifier("Apples_type_idx_btree")),
                     algorithm: BTreeAlgorithm { columns: 3.into() }.into(),
+                    accessor_name: "Apples_type_idx_btree".into(),
                 }
             ]
         );
diff --git a/crates/schema/src/def/validate/v9.rs b/crates/schema/src/def/validate/v9.rs
diff --git a/crates/schema/tests/ensure_same_schema.rs b/crates/schema/tests/ensure_same_schema.rs

Original file line number	Diff line number	Diff line change
`@@ -1257,8 +1257,6 @@ impl RelationalDB {`
`1257`	`1257`	`.map(\|s\| s.as_str())`
`1258`	`1258`	`.unwrap_or(table_name);`
`1259`	`1259`
`1260`		`- println!("replaced table name {table_name} with {new_table}");`
`1261`		`-`
`1262`	`1260`	`Ok(self.inner.table_id_from_name_mut_tx(tx, new_table)?)`
`1263`	`1261`	`}`
`1264`	`1262`
`@@ -1270,8 +1268,6 @@ impl RelationalDB {`
`1270`	`1268`	`.map(\|s\| s.as_str())`
`1271`	`1269`	`.unwrap_or(table_name);`
`1272`	`1270`
`1273`		`- println!("replaced table name {table_name} with {new_table}");`
`1274`		`-`
`1275`	`1271`	`Ok(self.inner.table_id_from_name_tx(tx, new_table)?)`
`1276`	`1272`	`}`
`1277`	`1273`
`@@ -1303,8 +1299,6 @@ impl RelationalDB {`
`1303`	`1299`	`.map(\|s\| s.as_str())`
`1304`	`1300`	`.unwrap_or(index_name);`
`1305`	`1301`
`1306`		`- println!("replaced index name {index_name} with {new_index_name}");`
`1307`		`-`
`1308`	`1302`	`Ok(self.inner.index_id_from_name_mut_tx(tx, new_index_name)?)`
`1309`	`1303`	`}`
`1310`	`1304`