Rust: macro change name -> accessor (#4264)

## Description of Changes

This PR primarily affects the `bindings-macro` and `schema` crates to
review:

### Core changes

1. Replaces the `name` macro with `accessor` for **Tables, Views,
Procedures, and Reducers** in Rust modules.
2. Extends `RawModuleDefV10` with a new section for:

   * case conversion policies
   * explicit names
    New sections are not validated in this PR so not functional.
3. Updates index behavior:

* Index names are now always **system-generated** for clients. Which
will be fixed in follow-up PR when we start validating RawModuleDef with
explicit names.
   * The `accessor` name for an index is used only inside the module.


## Breaking changes (API/ABI)

1. **Rust modules**

   * The `name` macro must be replaced with `accessor`.

2. **Client bindings (all languages)**

* Index names are now system-generated instead of using explicitly
provided names.


**Complexity:** 3

A follow-up PR will reintroduce explicit names with support for case
conversion.

---------

Co-authored-by: rekhoff <r.ekhoff@clockworklabs.io>
Co-authored-by: clockwork-labs-bot <clockwork-labs-bot@users.noreply.github.com>
Co-authored-by: clockwork-labs-bot <bot@clockworklabs.com>

Author: 4 people

crates/bindings-csharp/Runtime/Internal/Autogen/CaseConversionPolicy.g.cs

@@ -39,6 +39,7 @@ mod sym {
         };
     }
 
+    symbol!(accessor);
     symbol!(at);
     symbol!(auto_inc);
     symbol!(btree);

crates/bindings-macro/src/lib.rs

@@ -1,4 +1,4 @@
-use crate::reducer::{assert_only_lifetime_generics, extract_typed_args};
+use crate::reducer::{assert_only_lifetime_generics, extract_typed_args, generate_explicit_names_impl};
 use crate::sym;
 use crate::util::{check_duplicate, ident_to_litstr, match_meta};
 use proc_macro2::TokenStream;
@@ -29,11 +29,12 @@ impl ProcedureArgs {
     }
 }
 
-pub(crate) fn procedure_impl(args: ProcedureArgs, original_function: &ItemFn) -> syn::Result<TokenStream> {
+pub(crate) fn procedure_impl(_args: ProcedureArgs, original_function: &ItemFn) -> syn::Result<TokenStream> {
     let func_name = &original_function.sig.ident;
     let vis = &original_function.vis;
+    let explicit_name = _args.name.as_ref();
 
-    let procedure_name = args.name.unwrap_or_else(|| ident_to_litstr(func_name));
+    let procedure_name = ident_to_litstr(func_name);
 
     assert_only_lifetime_generics(original_function, "procedures")?;
 
@@ -86,6 +87,8 @@ pub(crate) fn procedure_impl(args: ProcedureArgs, original_function: &ItemFn) ->
         }
     };
 
+    let generate_explicit_names = generate_explicit_names_impl(&procedure_name.value(), func_name, explicit_name);
+
     Ok(quote! {
         const _: () = {
             #generated_describe_function
@@ -126,5 +129,7 @@ pub(crate) fn procedure_impl(args: ProcedureArgs, original_function: &ItemFn) ->
                 Some(<#ret_ty_for_info as spacetimedb::SpacetimeType>::make_type(ts))
             }
         }
+
+        #generate_explicit_names
     })
 }

crates/bindings-macro/src/procedure.rs

@@ -96,14 +96,18 @@ pub(crate) fn reducer_impl(args: ReducerArgs, original_function: &ItemFn) -> syn
     let func_name = &original_function.sig.ident;
     let vis = &original_function.vis;
 
-    let reducer_name = args.name.unwrap_or_else(|| ident_to_litstr(func_name));
+    let reducer_name = ident_to_litstr(func_name);
 
     assert_only_lifetime_generics(original_function, "reducers")?;
 
     let lifecycle = args.lifecycle.iter().filter_map(|lc| lc.to_lifecycle_value());
 
     let typed_args = extract_typed_args(original_function)?;
 
+    let explicit_name = args.name.as_ref();
+
+    let generate_explicit_names = generate_explicit_names_impl(&reducer_name.value(), func_name, explicit_name);
+
     // Extract all function parameter names.
     let opt_arg_names = typed_args.iter().map(|arg| {
         if let syn::Pat::Ident(i) = &*arg.pat {
@@ -165,5 +169,36 @@ pub(crate) fn reducer_impl(args: ReducerArgs, original_function: &ItemFn) -> syn
             const ARG_NAMES: &'static [Option<&'static str>] = &[#(#opt_arg_names),*];
             const INVOKE: Self::Invoke = #func_name::invoke;
         }
+
+        #generate_explicit_names
     })
 }
+
+pub(crate) fn generate_explicit_names_impl(
+    func_name: &str,
+    func_handle: &Ident,
+    explicit_name: Option<&LitStr>,
+) -> TokenStream {
+    let mut explicit_names_body = Vec::new();
+
+    // Table name
+    if let Some(explicit_name) = explicit_name {
+        explicit_names_body.push(quote! {
+            names.insert_function(
+                #func_name,
+                #explicit_name,
+            );
+        });
+    };
+
+    quote! {
+
+        impl spacetimedb::rt::ExplicitNames for #func_handle {
+            fn explicit_names() -> spacetimedb::spacetimedb_lib::ExplicitNames {
+                let mut names = spacetimedb::spacetimedb_lib::ExplicitNames::default();
+                #(#explicit_names_body)*
+                names
+            }
+        }
+    }
+}