Skip to content

Commit e4ae7c4

Browse files
authored
Fix unauth pulls from dockerhub (#4272)
# Description of Changes <!-- Please describe your change, mention any related tickets, and so on here. --> Apparently we ran too many unity testsuite jobs today and we got this: ``` Unable to find image 'unityci/editor:ubuntu-2022.3.32f1-linux-il2cpp-3' locally ubuntu-2022.3.32f1-linux-il2cpp-3: Pulling from unityci/editor docker: error from registry: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit ``` So now we login before pulling to increase our limit. # API and ABI breaking changes None <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> # Expected complexity level and risk 1 - this just logs us into docker before running the test <!-- How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change. This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code. If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways. --> # Testing <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> - [x] CI still passes
1 parent e1769b5 commit e4ae7c4

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -841,6 +841,12 @@ jobs:
841841
key: Unity-${{ github.head_ref }}
842842
restore-keys: Unity-
843843

844+
- name: Login to DockerHub
845+
uses: docker/login-action@v2
846+
with:
847+
username: ${{ vars.DOCKERHUB_USERNAME }}
848+
password: ${{ secrets.DOCKERHUB_PASSWORD }}
849+
844850
- name: Run Unity tests
845851
uses: game-ci/unity-test-runner@v4
846852
with:

0 commit comments

Comments
 (0)