Commit f1fe5db
authored
Update the defaultValue check to allow for falsy and undefined values (#4838)
# Description of Changes
This fixes a bug in TypeScript table default serialization where falsy
defaults like 0, '', false, and explicit undefined were treated as if no
default was provided. I did this as a property check in order to allow
`undefined` which becomes None() as the API allows `T | undefined`.
Closes: #4700
# API and ABI breaking changes
N/A
# Expected complexity level and risk
1 - Simple change to check the default value was added as a property
# Testing
- [x] Reproduced the failing issue in a simple throwaway project1 parent 6f23b19 commit f1fe5db
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
411 | 411 | | |
412 | 412 | | |
413 | 413 | | |
414 | | - | |
| 414 | + | |
| 415 | + | |
415 | 416 | | |
416 | 417 | | |
417 | 418 | | |
| |||
0 commit comments