* don't return raised js/Foo types for boolean, number, string

* remove ^boolean hint from array?
* fix tests
* add test inference test case for array?

Author: swannodette

src/main/cljs/cljs/core.cljs

@@ -243,7 +243,7 @@
   [x]
   (coercive-= x nil))
 
-(defn ^boolean array?
+(defn array?
   "Returns true if x is a JavaScript array."
   [x]
   (if (identical? *target* "nodejs")

src/main/clojure/cljs/analyzer.cljc

@@ -1122,7 +1122,12 @@
    (js-tag pre tag-type externs externs))
   ([pre tag-type externs top]
    (when-let [tag (get-in (resolve-extern pre externs) [:info tag-type])]
-     (lift-tag-to-js tag))))
+     (case tag
+       ;; don't lift these, analyze-dot will raise them for analysis
+       ;; representing these types as js/Foo is a hassle as it widens the
+       ;; return types unnecessarily i.e. #{boolean js/Boolean}
+       (boolean number string) tag
+       (lift-tag-to-js tag)))))
 
 (defn dotted-symbol? [sym]
   (let [s (str sym)]

src/test/clojure/cljs/externs_infer_tests.clj

@@ -106,7 +106,7 @@
     (is (= 'js/Console (ana/js-tag '[console] :tag externs)))
     (is (= 'js/Function (ana/js-tag '[console log] :tag externs)))
     (is (= 'js/undefined (ana/js-tag '[console log] :ret-tag externs)))
-    (is (= 'js/Boolean (ana/js-tag '[Number isNaN] :ret-tag externs)))
+    (is (= 'boolean (ana/js-tag '[Number isNaN] :ret-tag externs)))
     (is (= 'js/Foo (ana/js-tag '[baz] :ret-tag externs)))))
 
 (comment
@@ -148,23 +148,23 @@
                       (get @test-cenv ::ana/namespaces))))))))))))
 
 (deftest test-externs-type-infer
-  (is (= 'js/Boolean
+  (is (= 'boolean
         (-> (binding [ana/*cljs-ns* ana/*cljs-ns*]
               (env/with-compiler-env (env/default-compiler-env)
                 (analyze (ana/empty-env) '(.isNaN js/Number 1))))
           :tag)))
-  (is (= 'js/Boolean
+  (is (= 'boolean
         (-> (binding [ana/*cljs-ns* ana/*cljs-ns*]
               (env/with-compiler-env (env/default-compiler-env)
                 (analyze (ana/empty-env) '(js/Number.isNaN 1))))
           :tag)))
-  (is (= 'js/Boolean
+  (is (= 'boolean
         (-> (binding [ana/*cljs-ns* ana/*cljs-ns*]
               (env/with-compiler-env (env/default-compiler-env)
                 (analyze (ana/empty-env) '(let [x js/Number]
                                             (.isNaN x 1)))))
           :tag)))
-  (is (= 'js/Boolean
+  (is (= 'boolean
         (-> (binding [ana/*cljs-ns* ana/*cljs-ns*]
              (env/with-compiler-env (env/default-compiler-env)
                (analyze (ana/empty-env) '(js/isNaN 1))))
@@ -174,12 +174,12 @@
               (env/with-compiler-env (env/default-compiler-env)
                 (analyze (ana/empty-env) '(.generateKey js/crypto.subtle))))
           :tag)))
-  (is (= 'js/String
+  (is (= 'string
         (-> (binding [ana/*cljs-ns* ana/*cljs-ns*]
               (env/with-compiler-env (env/default-compiler-env)
                 (analyze (ana/empty-env) '(.toUpperCase "foo"))))
           :tag)))
-  (is (= 'js/Boolean
+  (is (= 'boolean
         (-> (binding [ana/*cljs-ns* ana/*cljs-ns*]
               (env/with-compiler-env (env/default-compiler-env)
                 (analyze (ana/empty-env) '(.isArray js/Array (array)))))

src/test/clojure/cljs/type_inference_tests.clj

@@ -313,6 +313,13 @@
   ;      'clj))
   )
 
+(deftest lib-inference-extern-call
+  (testing "Test return type inference for core fns whose
+  internal implementation uses standard JS APIs"
+    (is (= 'boolean
+          (env/with-compiler-env test-cenv
+            (:tag (analyze test-env '(array? (array)))))))))
+
 (deftest test-always-true-if
   (is (= (env/with-compiler-env test-cenv
            (:tag (analyze test-env '(if 1 2 "foo"))))