Merge pull request #139 from Verimatrix/dummy-task-def-updates

fix: Support update hook for DummyTaskDefinition (resolves #140)

Author: hupe1980

packages/cdk-blue-green-container-deployment/src/__tests__/__snapshots__/dummy-task-definition.test.ts.snap

@@ -116,6 +116,21 @@ Object {
             "Arn",
           ],
         },
+        "Update": Object {
+          "Fn::Join": Array [
+            "",
+            Array [
+              "{\\"service\\":\\"ECS\\",\\"action\\":\\"registerTaskDefinition\\",\\"parameters\\":{\\"requiresCompatibilities\\":[\\"FARGATE\\"],\\"family\\":\\"c86e1e5d419d3c124c7e40411b7e7805f91621e162\\",\\"executionRoleArn\\":\\"",
+              Object {
+                "Fn::GetAtt": Array [
+                  "DummyTaskDefinitionExecutionRole715DBD43",
+                  "Arn",
+                ],
+              },
+              "\\",\\"networkMode\\":\\"awsvpc\\",\\"cpu\\":\\"256\\",\\"memory\\":\\"512\\",\\"containerDefinitions\\":[{\\"name\\":\\"sample-website\\",\\"image\\":\\"image\\",\\"portMappings\\":[{\\"hostPort\\":80,\\"protocol\\":\\"tcp\\",\\"containerPort\\":80}]}]},\\"physicalResourceId\\":{\\"responsePath\\":\\"taskDefinition.taskDefinitionArn\\"}}",
+            ],
+          ],
+        },
       },
       "Type": "Custom::DummyTaskDefinition",
       "UpdateReplacePolicy": "Delete",

packages/cdk-blue-green-container-deployment/src/dummy-task-definition.ts

@@ -1,7 +1,7 @@
 import { NetworkMode } from '@aws-cdk/aws-ecs';
 import { Role, ServicePrincipal, ManagedPolicy, PolicyStatement, Effect, IRole } from '@aws-cdk/aws-iam';
 import { Construct } from '@aws-cdk/core';
-import { AwsCustomResource, AwsCustomResourcePolicy, PhysicalResourceId, PhysicalResourceIdReference } from '@aws-cdk/custom-resources';
+import { AwsCustomResource, AwsCustomResourcePolicy, AwsSdkCall, PhysicalResourceId, PhysicalResourceIdReference } from '@aws-cdk/custom-resources';
 
 export interface IDummyTaskDefinition {
   readonly executionRole: IRole;
@@ -63,41 +63,46 @@ export class DummyTaskDefinition extends Construct implements IDummyTaskDefiniti
     this.containerName = props.containerName ?? 'sample-website';
     this.containerPort = props.containerPort ?? 80;
 
-    const taskDefinition = new AwsCustomResource(this, 'DummyTaskDefinition', {
-      resourceType: 'Custom::DummyTaskDefinition',
-      onCreate: {
-        service: 'ECS',
-        action: 'registerTaskDefinition',
-        parameters: {
-          requiresCompatibilities: ['FARGATE'],
-          family: this.family,
-          executionRoleArn: this.executionRole.roleArn,
-          networkMode: NetworkMode.AWS_VPC,
-          cpu: '256',
-          memory: '512',
-          containerDefinitions: [
-            {
-              name: this.containerName,
-              image: props.image,
-              portMappings: [
-                {
-                  hostPort: this.containerPort,
-                  protocol: 'tcp',
-                  containerPort: this.containerPort,
-                },
-              ],
-            },
-          ],
-        },
-        physicalResourceId: PhysicalResourceId.fromResponse('taskDefinition.taskDefinitionArn'),
+    const registerTaskDefinition: AwsSdkCall = {
+      service: 'ECS',
+      action: 'registerTaskDefinition',
+      parameters: {
+        requiresCompatibilities: ['FARGATE'],
+        family: this.family,
+        executionRoleArn: this.executionRole.roleArn,
+        networkMode: NetworkMode.AWS_VPC,
+        cpu: '256',
+        memory: '512',
+        containerDefinitions: [
+          {
+            name: this.containerName,
+            image: props.image,
+            portMappings: [
+              {
+                hostPort: this.containerPort,
+                protocol: 'tcp',
+                containerPort: this.containerPort,
+              },
+            ],
+          },
+        ],
       },
-      onDelete: {
-        service: 'ECS',
-        action: 'deregisterTaskDefinition',
-        parameters: {
-          taskDefinition: new PhysicalResourceIdReference(),
-        },
+      physicalResourceId: PhysicalResourceId.fromResponse('taskDefinition.taskDefinitionArn'),
+    };
+
+    const deregisterTaskDefinition: AwsSdkCall = {
+      service: 'ECS',
+      action: 'deregisterTaskDefinition',
+      parameters: {
+        taskDefinition: new PhysicalResourceIdReference(),
       },
+    };
+
+    const taskDefinition = new AwsCustomResource(this, 'DummyTaskDefinition', {
+      resourceType: 'Custom::DummyTaskDefinition',
+      onCreate: registerTaskDefinition,
+      onUpdate: registerTaskDefinition,
+      onDelete: deregisterTaskDefinition,
       policy: AwsCustomResourcePolicy.fromStatements([
         new PolicyStatement({
           effect: Effect.ALLOW,