Skip to content

Commit 5ef29d9

Browse files
author
seolmin
committed
fix: add skip_error_log option to meta of error when error occurs in service
1 parent 2371cb5 commit 5ef29d9

3 files changed

Lines changed: 7 additions & 9 deletions

File tree

src/spaceone/core/fastapi/api.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,8 @@ async def wrapper(*args, **kwargs):
4545

4646

4747
def _print_error_log(error):
48-
_LOGGER.error(f'(Error) => {error.message} {error}',
49-
extra={'error_code': error.error_code,
50-
'error_message': error.message,
51-
'traceback': traceback.format_exc()})
48+
if not error.meta.get('skip_error_log'):
49+
_LOGGER.error(f'(Error) => {error.message} {error}', exc_info=True)
5250

5351

5452
def _raise_exception(error):
@@ -61,7 +59,6 @@ def _check_http_status_code(grpc_status_code: str) -> int:
6159

6260

6361
class BaseAPI(object):
64-
6562
locator = Locator()
6663
service = None
6764

src/spaceone/core/pygrpc/api.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,9 @@ def get_minimal(params):
6464
def _error_method(error, context):
6565
if not isinstance(error, ERROR_BASE):
6666
error = ERROR_UNKNOWN(message=error)
67-
_LOGGER.error(f'(Error) => {error.message} {error}',
68-
extra={'error_code': error.error_code,
69-
'error_message': error.message,
70-
'traceback': traceback.format_exc()})
67+
68+
if not error.meta.get('skip_error_log'):
69+
_LOGGER.error(f'(Error) => {error.message} {error}', exc_info=True)
7170

7271
details = f'{error.error_code}: {error.message}'
7372
context.abort(grpc.StatusCode[error.status_code], details)

src/spaceone/core/service/service.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,8 @@ def _error_handler(self, error):
158158
if not isinstance(error, ERROR_BASE):
159159
error = ERROR_UNKNOWN(message=error)
160160

161+
error.meta['skip_error_log'] = True
162+
161163
# Failure Event
162164
if _check_handler_method(self, 'event'):
163165
for handler in self.handler['event']['handlers']:

0 commit comments

Comments
 (0)