Skip to content

Commit 67f7862

Browse files
committed
Fix access_rules_controller permissions query
- Replace non-existent readable_space_scoped_space_guids_query with proper subquery - Use readable_space_scoped_spaces_query for non-global readers - Handle global readers separately with all routes
1 parent df1ac2f commit 67f7862

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

app/controllers/v3/access_rules_controller.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,12 @@ def destroy
107107
def build_dataset(message)
108108
dataset = VCAP::CloudController::RouteAccessRule.dataset
109109

110-
readable_route_ids = VCAP::CloudController::Route.
111-
join(:spaces, id: :space_id).
112-
where(Sequel.lit(permission_queryer.readable_space_scoped_space_guids_query)).
113-
select(:routes__id)
110+
if permission_queryer.can_read_globally?
111+
readable_route_ids = VCAP::CloudController::Route.select(:id)
112+
else
113+
readable_space_ids = permission_queryer.readable_space_scoped_spaces_query.select(:id)
114+
readable_route_ids = VCAP::CloudController::Route.where(space_id: readable_space_ids).select(:id)
115+
end
114116

115117
dataset = dataset.where(route_id: readable_route_ids)
116118

0 commit comments

Comments
 (0)