Raise error if update request is nil

Author: kathap

app/jobs/v3/services/update_broker_job.rb

@@ -47,6 +47,8 @@ class Perform
         def initialize(update_request_guid, previous_broker_state, user_audit_info:)
           @update_request_guid = update_request_guid
           @update_request = ServiceBrokerUpdateRequest.find(guid: update_request_guid)
+          raise 'Service broker update request not found' if @update_request.nil?
+
           @broker = ServiceBroker.find(id: @update_request.service_broker_id)
           @previous_broker_state = previous_broker_state
           @catalog_updater = VCAP::CloudController::V3::ServiceBrokerCatalogUpdater.new(@broker, user_audit_info:)

spec/unit/jobs/v3/services/update_broker_job_spec.rb

@@ -491,6 +491,16 @@ module V3
             end
           end
 
+          context 'when the update request is deleted before job runs' do
+            before do
+              allow(ServiceBrokerUpdateRequest).to receive(:find).with(guid: update_broker_request.guid).and_return(nil)
+            end
+
+            it 'raises an error with a clear message' do
+              expect { job.perform }.to raise_error(RuntimeError, 'Service broker update request not found')
+            end
+          end
+
           def setup_broker_with_invalid_catalog
             catalog = instance_double(Services::ServiceBrokers::V2::Catalog)