Make cutoff_age_in_days a named parameter

- Change initialize signature to use keyword argument: cutoff_age_in_days:
- Rename internal variable @days_ago to @cutoff_age_in_days for consistency

Author: joyvuu-dave

app/jobs/runtime/events_cleanup.rb

@@ -9,7 +9,7 @@ def initialize(cutoff_age_in_days)
         end
 
         def perform
-          Database::OldRecordCleanup.new(Event, cutoff_age_in_days).delete
+          Database::OldRecordCleanup.new(Event, cutoff_age_in_days:).delete
         end
 
         def job_name_in_configuration

app/repositories/app_usage_event_repository.rb

@@ -152,7 +152,7 @@ def purge_and_reseed_started_apps!
       end
 
       def delete_events_older_than(cutoff_age_in_days)
-        Database::OldRecordCleanup.new(AppUsageEvent, cutoff_age_in_days, keep_at_least_one_record: true).delete
+        Database::OldRecordCleanup.new(AppUsageEvent, cutoff_age_in_days: cutoff_age_in_days, keep_at_least_one_record: true).delete
       end
 
       private

app/repositories/service_usage_event_repository.rb

@@ -92,7 +92,7 @@ def purge_and_reseed_service_instances!
       end
 
       def delete_events_older_than(cutoff_age_in_days)
-        Database::OldRecordCleanup.new(ServiceUsageEvent, cutoff_age_in_days, keep_at_least_one_record: true).delete
+        Database::OldRecordCleanup.new(ServiceUsageEvent, cutoff_age_in_days: cutoff_age_in_days, keep_at_least_one_record: true).delete
       end
     end
   end

lib/database/old_record_cleanup.rb

@@ -3,16 +3,16 @@
 module Database
   class OldRecordCleanup
     class NoCurrentTimestampError < StandardError; end
-    attr_reader :model, :days_ago, :keep_at_least_one_record
+    attr_reader :model, :cutoff_age_in_days, :keep_at_least_one_record
 
-    def initialize(model, days_ago, keep_at_least_one_record: false)
+    def initialize(model, cutoff_age_in_days:, keep_at_least_one_record: false)
       @model = model
-      @days_ago = days_ago
+      @cutoff_age_in_days = cutoff_age_in_days
       @keep_at_least_one_record = keep_at_least_one_record
     end
 
     def delete
-      cutoff_date = current_timestamp_from_database - days_ago.to_i.days
+      cutoff_date = current_timestamp_from_database - cutoff_age_in_days.to_i.days
 
       old_records = model.dataset.where(Sequel.lit('created_at < ?', cutoff_date))
       if keep_at_least_one_record

spec/unit/lib/database/old_record_cleanup_spec.rb

@@ -9,7 +9,7 @@
     let!(:fresh_event) { VCAP::CloudController::Event.make(created_at: 1.day.ago + 1.minute) }
 
     it 'deletes records older than specified days' do
-      record_cleanup = Database::OldRecordCleanup.new(VCAP::CloudController::Event, 1)
+      record_cleanup = Database::OldRecordCleanup.new(VCAP::CloudController::Event, cutoff_age_in_days: 1)
 
       expect do
         record_cleanup.delete
@@ -22,7 +22,7 @@
 
     context "when there are no records at all but you're trying to keep at least one" do
       it "doesn't keep one because there aren't any to keep" do
-        record_cleanup = Database::OldRecordCleanup.new(VCAP::CloudController::ServiceUsageEvent, 1, keep_at_least_one_record: true)
+        record_cleanup = Database::OldRecordCleanup.new(VCAP::CloudController::ServiceUsageEvent, cutoff_age_in_days: 1, keep_at_least_one_record: true)
 
         expect { record_cleanup.delete }.not_to raise_error
         expect(VCAP::CloudController::ServiceUsageEvent.count).to eq(0)
@@ -31,12 +31,12 @@
 
     it 'only retrieves the current timestamp from the database once' do
       expect(VCAP::CloudController::Event.db).to receive(:fetch).with('SELECT CURRENT_TIMESTAMP as now').once.and_call_original
-      record_cleanup = Database::OldRecordCleanup.new(VCAP::CloudController::Event, 1)
+      record_cleanup = Database::OldRecordCleanup.new(VCAP::CloudController::Event, cutoff_age_in_days: 1)
       record_cleanup.delete
     end
 
     it 'keeps the last row when :keep_at_least_one_record is true even if it is older than the cutoff date' do
-      record_cleanup = Database::OldRecordCleanup.new(VCAP::CloudController::Event, 0, keep_at_least_one_record: true)
+      record_cleanup = Database::OldRecordCleanup.new(VCAP::CloudController::Event, cutoff_age_in_days: 0, keep_at_least_one_record: true)
 
       expect do
         record_cleanup.delete