Skip to content

Commit d1f841f

Browse files
authored
Merge pull request #981 from cloudinary/fix/fatal-error-trait-params
Discard faulty params
2 parents 8f87b39 + dffb5c8 commit d1f841f

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

php/traits/trait-params.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,15 @@ protected function set_param_array( $parts, $param, $value ) {
5353
return $new;
5454
}
5555

56-
if ( '' === $key ) {
57-
$new[] = $value;
56+
if ( is_array( $new ) ) {
57+
if ( '' === $key ) {
58+
$new[] = $value;
59+
} else {
60+
$new[ $key ] = $value;
61+
}
5862
} else {
59-
$new[ $key ] = $value;
63+
// There's likely a problem here, as we're setting an array key on a non-array.
64+
$new = array();
6065
}
6166
// @TODO: I took ksort out, need to check that it doesn't have any problems being.
6267

0 commit comments

Comments
 (0)