fix: prevent php warning in looks_like_json function

epigeyre · web-flow · commit dc772d852b29 · 2024-08-22T19:01:39.000+02:00
If $thing only contains a space it will generate a php warning when doing ltrim( $thing )[0]. This fixes the issue while still being compatible with php 5.4+.
diff --git a/php/class-utils.php b/php/class-utils.php
@@ -543,7 +543,7 @@ public static function pathinfo( $path, $flags = 15 ) {
 	 * @return bool
 	 */
 	public static function looks_like_json( $thing ) {
-		return ! empty( $thing ) && is_string( $thing ) && in_array( ltrim( $thing )[0], array( '{', '[' ), true );
+		return is_string( $thing ) && ! empty( ltrim( $thing ) ) && in_array( $thing[0], array( '{', '[' ), true );
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -543,7 +543,7 @@ public static function pathinfo( $path, $flags = 15 ) {`
`543`	`543`	`* @return bool`
`544`	`544`	`*/`
`545`	`545`	`public static function looks_like_json( $thing ) {`
`546`		`- return ! empty( $thing ) && is_string( $thing ) && in_array( ltrim( $thing )[0], array( '{', '[' ), true );`
	`546`	`+ return is_string( $thing ) && ! empty( ltrim( $thing ) ) && in_array( $thing[0], array( '{', '[' ), true );`
`547`	`547`	`}`
`548`	`548`
`549`	`549`	`/**`