add support to create snapshots at project level using csi driver

Author: Pearl1594

examples/k8s/snapshot/pvc-from-snapshot.yaml

@@ -7,7 +7,7 @@ spec:
     - ReadWriteOnce
   resources:
     requests:
-      storage: 10Gi
+      storage: 1Gi
   dataSource:
     name: snapshot-1
     kind: VolumeSnapshot

pkg/cloud/snapshots.go

@@ -6,13 +6,22 @@ import (
 
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
+	"k8s.io/klog/v2"
 )
 
 func (c *client) GetSnapshotByID(ctx context.Context, snapshotID ...string) (*Snapshot, error) {
+	logger := klog.FromContext(ctx)
 	p := c.Snapshot.NewListSnapshotsParams()
 	if snapshotID != nil {
 		p.SetId(snapshotID[0])
 	}
+	if c.projectID != "" {
+		p.SetProjectid(c.projectID)
+	}
+	logger.V(2).Info("CloudStack API call", "command", "ListSnapshots", "params", map[string]string{
+		"id":        snapshotID[0],
+		"projectid": c.projectID,
+	})
 	l, err := c.Snapshot.ListSnapshots(p)
 	if err != nil {
 		return nil, err
@@ -37,7 +46,13 @@ func (c *client) GetSnapshotByID(ctx context.Context, snapshotID ...string) (*Sn
 }
 
 func (c *client) CreateSnapshot(ctx context.Context, volumeID string) (*Snapshot, error) {
+	logger := klog.FromContext(ctx)
 	p := c.Snapshot.NewCreateSnapshotParams(volumeID)
+
+	logger.V(2).Info("CloudStack API call", "command", "CreateSnapshot", "params", map[string]string{
+		"volumeid": volumeID,
+	})
+
 	snapshot, err := c.Snapshot.CreateSnapshot(p)
 	if err != nil {
 		return nil, status.Errorf(codes.Internal, "Error %v", err)

pkg/cloud/volumes.go

@@ -166,10 +166,6 @@ func (c *client) ExpandVolume(ctx context.Context, volumeID string, newSizeInGB
 
 func (c *client) CreateVolumeFromSnapshot(ctx context.Context, zoneID, name, domainID, projectID, snapshotID string, sizeInGB int64) (*Volume, error) {
 	logger := klog.FromContext(ctx)
-	snapshot, _, err := c.Snapshot.GetSnapshotByID(snapshotID)
-	if err != nil {
-		return nil, fmt.Errorf("failed to retrieve snapshot '%s': %w", snapshotID, err)
-	}
 
 	p := c.Volume.NewCreateVolumeParams()
 	p.SetZoneid(zoneID)
@@ -178,7 +174,7 @@ func (c *client) CreateVolumeFromSnapshot(ctx context.Context, zoneID, name, dom
 	}
 	p.SetName(name)
 	p.SetSize(sizeInGB)
-	p.SetSnapshotid(snapshot.Id)
+	p.SetSnapshotid(snapshotID)
 
 	logger.V(2).Info("CloudStack API call", "command", "CreateVolume", "params", map[string]string{
 		"name":       name,

pkg/driver/controller.go

@@ -332,9 +332,10 @@ func (cs *controllerServer) CreateSnapshot(ctx context.Context, req *csi.CreateS
 		// Error with CloudStack
 		return nil, status.Errorf(codes.Internal, "Error %v", err)
 	}
+	klog.V(4).Infof("CreateSnapshot of volume: %s", volume)
 	snapshot, err := cs.connector.CreateSnapshot(ctx, volume.ID)
 	if err != nil {
-		return nil, status.Errorf(codes.Internal, "Failed to create snapshot %s: %v", snapshot.ID, err.Error())
+		return nil, status.Errorf(codes.Internal, "Failed to create snapshot for volume %s: %v", volume.ID, err.Error())
 	}
 
 	t, err := time.Parse("2006-01-02T15:04:05-0700", snapshot.CreatedAt)