Skip to content

Commit 47980af

Browse files
authored
change setting name to minShowDelay (microsoft#261458)
1 parent 3e02f7c commit 47980af

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/vs/editor/common/config/editorOptions.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4363,7 +4363,7 @@ export interface IInlineSuggestOptions {
43634363

43644364
suppressSuggestions?: boolean;
43654365

4366-
minimalDelay?: number;
4366+
minShowDelay?: number;
43674367

43684368
/**
43694369
* Does not clear active inline suggestions when the editor loses focus.
@@ -4426,7 +4426,7 @@ class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, I
44264426
keepOnBlur: false,
44274427
fontFamily: 'default',
44284428
syntaxHighlightingEnabled: true,
4429-
minimalDelay: 0,
4429+
minShowDelay: 0,
44304430
edits: {
44314431
enabled: true,
44324432
showCollapsed: false,
@@ -4468,12 +4468,12 @@ class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, I
44684468
default: defaults.suppressSuggestions,
44694469
description: nls.localize('inlineSuggest.suppressSuggestions', "Controls how inline suggestions interact with the suggest widget. If enabled, the suggest widget is not shown automatically when inline suggestions are available.")
44704470
},
4471-
'editor.inlineSuggest.minimalDelay': {
4471+
'editor.inlineSuggest.minShowDelay': {
44724472
type: 'number',
44734473
default: 0,
44744474
minimum: 0,
44754475
maximum: 10000,
4476-
description: nls.localize('inlineSuggest.minimalDelay', "Controls the minimal delay in milliseconds after which inline suggestions are shown after typing."),
4476+
description: nls.localize('inlineSuggest.minShowDelay', "Controls the minimal delay in milliseconds after which inline suggestions are shown after typing."),
44774477
},
44784478
'editor.inlineSuggest.experimental.suppressInlineSuggestions': {
44794479
type: 'string',
@@ -4539,7 +4539,7 @@ class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, I
45394539
keepOnBlur: boolean(input.keepOnBlur, this.defaultValue.keepOnBlur),
45404540
fontFamily: EditorStringOption.string(input.fontFamily, this.defaultValue.fontFamily),
45414541
syntaxHighlightingEnabled: boolean(input.syntaxHighlightingEnabled, this.defaultValue.syntaxHighlightingEnabled),
4542-
minimalDelay: EditorIntOption.clampedInt(input.minimalDelay, 0, 0, 10000),
4542+
minShowDelay: EditorIntOption.clampedInt(input.minShowDelay, 0, 0, 10000),
45434543
edits: {
45444544
enabled: boolean(input.edits?.enabled, this.defaultValue.edits.enabled),
45454545
showCollapsed: boolean(input.edits?.showCollapsed, this.defaultValue.edits.showCollapsed),

src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsModel.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export class InlineCompletionsModel extends Disposable {
9696
private readonly _inlineEditsEnabled;
9797
private readonly _inlineEditsShowCollapsedEnabled;
9898
private readonly _triggerCommandOnProviderChange;
99-
private readonly _minimalDelay;
99+
private readonly _minShowDelay;
100100

101101
constructor(
102102
public readonly textModel: ITextModel,
@@ -126,7 +126,7 @@ export class InlineCompletionsModel extends Disposable {
126126
this._inlineEditsEnabled = this._editorObs.getOption(EditorOption.inlineSuggest).map(v => !!v.edits.enabled);
127127
this._inlineEditsShowCollapsedEnabled = this._editorObs.getOption(EditorOption.inlineSuggest).map(s => s.edits.showCollapsed);
128128
this._triggerCommandOnProviderChange = this._editorObs.getOption(EditorOption.inlineSuggest).map(s => s.experimental.triggerCommandOnProviderChange);
129-
this._minimalDelay = this._editorObs.getOption(EditorOption.inlineSuggest).map(s => s.minimalDelay);
129+
this._minShowDelay = this._editorObs.getOption(EditorOption.inlineSuggest).map(s => s.minShowDelay);
130130
this._typing = this._register(new TypingInterval(this.textModel));
131131

132132
this._register(this._inlineCompletionsService.onDidChangeIsSnoozing((isSnoozing) => {
@@ -390,7 +390,7 @@ export class InlineCompletionsModel extends Disposable {
390390
includeInlineCompletions: !changeSummary.onlyRequestInlineEdits,
391391
includeInlineEdits: this._inlineEditsEnabled.read(reader),
392392
requestIssuedDateTime: requestInfo.startTime,
393-
earliestShownDateTime: requestInfo.startTime + this._minimalDelay.get(),
393+
earliestShownDateTime: requestInfo.startTime + this._minShowDelay.get(),
394394
};
395395

396396
if (context.triggerKind === InlineCompletionTriggerKind.Automatic && changeSummary.textChange) {

src/vs/monaco.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4769,7 +4769,7 @@ declare namespace monaco.editor {
47694769
showToolbar?: 'always' | 'onHover' | 'never';
47704770
syntaxHighlightingEnabled?: boolean;
47714771
suppressSuggestions?: boolean;
4772-
minimalDelay?: number;
4772+
minShowDelay?: number;
47734773
/**
47744774
* Does not clear active inline suggestions when the editor loses focus.
47754775
*/

0 commit comments

Comments
 (0)