Skip to content

Commit 5923367

Browse files
authored
Merge branch 'main' into eli/empty-add
2 parents 6033e83 + 85f2ce8 commit 5923367

134 files changed

Lines changed: 2516 additions & 1090 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/CODEOWNERS

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,25 @@ src/vs/base/browser/domSanitize.ts @mjbvz
2929
src/vs/base/parts/sandbox/** @bpasero @deepak1556
3030
src/vs/base/parts/storage/** @bpasero @deepak1556
3131
src/vs/platform/backup/** @bpasero
32+
src/vs/platform/editor/** @bpasero @benibenj
3233
src/vs/platform/files/** @bpasero @deepak1556
3334
src/vs/base/node/pfs.ts @bpasero @deepak1556
3435
src/vs/code/** @bpasero @deepak1556
35-
src/vs/workbench/contrib/update/browser/releaseNotesEditor.ts @alexr00 @joaomoreno
36+
src/vs/workbench/services/auxiliaryWindow/** @bpasero
37+
src/vs/workbench/services/editor/** @bpasero @benibenj
38+
src/vs/workbench/services/files/** @bpasero
39+
src/vs/workbench/services/history/** @bpasero
40+
src/vs/workbench/services/host/** @bpasero
41+
src/vs/workbench/services/layout/** @bpasero @benibenj
42+
src/vs/workbench/services/lifecycle/** @bpasero
43+
src/vs/workbench/services/notification/** @bpasero
44+
src/vs/workbench/services/untitled/** @bpasero
3645
src/vs/workbench/services/textfile/** @bpasero
3746
src/vs/workbench/services/workingCopy/** @bpasero
47+
src/vs/workbench/common/** @bpasero @benibenj @sandy081
48+
src/vs/workbench/browser/** @bpasero @benibenj @sandy081
49+
src/vs/workbench/electron-browser/** @bpasero @benibenj @sandy081
50+
src/vs/workbench/contrib/update/browser/releaseNotesEditor.ts @alexr00 @joaomoreno
3851

3952
# ensure the API police is aware of changes to the vscode-dts file
4053
# this is only about the final API, not about proposed API changes

.github/chatmodes/Plan.chatmode.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
---
22
description: Research and draft an implementation plan
3-
tools: ['search', 'executeTask', 'usages', 'problems', 'get_issue', 'get_issue_comments', 'fetch', 'githubRepo']
3+
tools: ['executePrompt', 'usages', 'problems', 'githubRepo', 'github.vscode-pull-request-github/activePullRequest', 'search', 'github/get_issue', 'github/get_issue_comments', 'github/get_issue', 'github/get_issue_comments', 'fetch']
44
---
55
You are pairing with the user to create a clear, detailed, and actionable plan for the given task, iterating through a <workflow> of gathering context and drafting the plan for review.
66

77
<workflow>
88
Comprehensive context gathering for planning following <plan_research>:
9-
- IF `execute_task` tool is available: MUST run `execute_task` tool, prompted not to NOT pause for user feedback, and to follow <plan_research> and write a <plan_draft>.
10-
- ELSE (`execute_task` tool is NOT available): Run <plan_research> via tools yourself, following research_actions.
11-
- Present the plan to the user for feedback and refinement:
9+
1. Context gathering and research:
10+
- MUST run `execute_prompt` tool: Instruct the agent to work autonomously without pausing for user feedback, following <plan_research> to gather context and writing a complete <plan_draft> to return to you.
11+
- If `execute_prompt` tool is NOT available: Run <plan_research> via tools yourself.
12+
2. Present the plan to the user for feedback and refinement:
1213
- Highlights key areas of ambiguity with specific questions and suggestions.
1314
- MANDATORY: Pause for user feedback!
14-
- Handle feedback: Refine the plan directly or research further if more context is needed.
15+
- Handle feedback: Refine the plan after doing further context gathering and research.
1516
</workflow>
1617

1718
<plan_research>
@@ -24,10 +25,10 @@ Comprehensive information gathering using read-only tools:
2425
</plan_research>
2526

2627
<plan_draft>
27-
- Clear, concise, non-repetitive, and high-signal, or it will be too long to read
28-
- Tailored to the request and context:
29-
- Higher complexity requires more detail
30-
- Higher ambiguity requires more exploration of alternatives
28+
- Style:
29+
- Clear, concise, non-repetitive, and high-signal; optimized for quick human review
30+
- Rich in references to specific/related files, symbols, and documentation; while avoiding excessive code snippets
31+
- Tailored to the task and context: Higher complexity requires more detail, higher ambiguity more alternative approaches, etc.
3132
- Briefly summarize problem understanding and proposed technical approach
3233
- Implementation plan broken down into clear, iterative steps as ordered markdown list
3334
- Call out any steps that are too vague or ambiguous to act on
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
mode: Plan
3-
description: Deep plan
3+
description: Clarify before planning in more detail
44
---
5-
Before doing your research discover related code (5 tool calls max) as high-level overview, then ask 3 clarifying questions. Once the user answered, go to *Research*.
5+
Before doing your research look up related code (max 5 tool calls!) to get a high-level overview, then ask 3 clarifying questions. Once the user answered, go to *Context gathering and research*.
66

77
Be extra detailed in your planning draft.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
22
mode: Plan
3-
description: Fast plan
3+
description: Iterate quicker on simple tasks
44
---
5-
Research as usual, but draft a much more shorter implementation plan.
5+
Planning for faster iteration: Research as usual, but draft a much more shorter implementation plan that focused on just the main steps

.github/prompts/plan.prompt.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
mode: agent
33
description: 'Start planning'
4-
tools: ['getNotebookSummary', 'readNotebookCellOutput', 'search', 'getTerminalOutput', 'terminalSelection', 'terminalLastCommand', 'usages', 'vscodeAPI', 'think', 'problems', 'changes', 'testFailure', 'fetch', 'githubRepo', 'todos', 'get_issue', 'get_issue_comments', 'get_me']
4+
tools: ['runNotebooks/getNotebookSummary', 'runNotebooks/readNotebookCellOutput', 'search', 'runCommands/getTerminalOutput', 'runCommands/terminalSelection', 'runCommands/terminalLastCommand', 'usages', 'vscodeAPI', 'think', 'problems', 'changes', 'testFailure', 'fetch', 'githubRepo', 'todos', 'github/get_issue', 'github/get_issue_comments', 'github/get_me']
55
---
66
Your goal is to prepare a detailed plan to fix the bug or add the new feature, for this you first need to:
77
* Understand the context of the bug or feature by reading the issue description and comments.

.npmrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
disturl="https://electronjs.org/headers"
2-
target="37.5.1"
3-
ms_build_id="12409799"
2+
target="37.6.0"
3+
ms_build_id="12502201"
44
runtime="electron"
55
build_from_source="true"
66
legacy-peer-deps="true"

.vscode/notebooks/my-endgame.github-issues

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@
99
"language": "github-issues",
1010
"value": "$MILESTONE=milestone:\"September 2025\"\n\n$MINE=assignee:@me"
1111
},
12+
{
13+
"kind": 2,
14+
"language": "github-issues",
15+
"value": "$NOT_TEAM_MEMBERS=-author:aeschli -author:alexdima -author:alexr00 -author:AmandaSilver -author:bamurtaugh -author:bpasero -author:chrmarti -author:Chuxel -author:claudiaregio -author:connor4312 -author:dbaeumer -author:deepak1556 -author:devinvalenciano -author:digitarald -author:DonJayamanne -author:egamma -author:fiveisprime -author:ntrogh -author:hediet -author:isidorn -author:joaomoreno -author:jrieken -author:kieferrm -author:lramos15 -author:lszomoru -author:meganrogge -author:misolori -author:mjbvz -author:rebornix -author:roblourens -author:rzhao271 -author:sandy081 -author:sbatten -author:stevencl -author:TylerLeonhardt -author:Tyriar -author:weinand -author:amunger -author:karthiknadig -author:eleanorjboyd -author:Yoyokrazy -author:ulugbekna -author:aiday-mar -author:bhavyaus -author:justschen -author:benibenj -author:luabud -author:anthonykim1 -author:joshspicer -author:osortega -author:hawkticehurst -author:pierceboggan -author:benvillalobos -author:dileepyavan -author:dineshc-msft -author:dmitrivMS -author:eli-w-king -author:jo-oikawa -author:jruales -author:jytjyt05 -author:kycutler -author:mrleemurray -author:pwang347 -author:vijayupadya"
16+
},
1217
{
1318
"kind": 1,
1419
"language": "markdown",
@@ -157,7 +162,7 @@
157162
{
158163
"kind": 2,
159164
"language": "github-issues",
160-
"value": "org:microsoft $MILESTONE -$MINE is:issue is:closed reason:completed sort:updated-asc label:bug -label:unreleased -label:verified -label:z-author-verified -label:on-testplan -label:*duplicate -label:duplicate -label:invalid -label:*as-designed -label:*out-of-scope -label:error-telemetry -label:verification-steps-needed -label:verification-found -author:aeschli -author:alexdima -author:alexr00 -author:AmandaSilver -author:andreamah -author:bamurtaugh -author:bpasero -author:chrmarti -author:Chuxel -author:claudiaregio -author:connor4312 -author:dbaeumer -author:deepak1556 -author:devinvalenciano -author:digitarald -author:DonJayamanne -author:egamma -author:fiveisprime -author:ntrogh -author:hediet -author:isidorn -author:joaomoreno -author:jrieken -author:kieferrm -author:lramos15 -author:lszomoru -author:meganrogge -author:misolori -author:mjbvz -author:rebornix -author:roblourens -author:rzhao271 -author:sandy081 -author:sbatten -author:stevencl -author:tanhakabir -author:TylerLeonhardt -author:Tyriar -author:weinand -author:amunger -author:karthiknadig -author:eleanorjboyd -author:Yoyokrazy -author:paulacamargo25 -author:ulugbekna -author:aiday-mar -author:bhavyaus -author:justschen -author:benibenj -author:luabud -author:anthonykim1 -author:joshspicer -author:osortega -author:hawkticehurst -author:pierceboggan"
165+
"value": "org:microsoft $MILESTONE -$MINE is:issue is:closed reason:completed sort:updated-asc label:bug -label:unreleased -label:verified -label:z-author-verified -label:on-testplan -label:*duplicate -label:duplicate -label:invalid -label:*as-designed -label:*out-of-scope -label:error-telemetry -label:verification-steps-needed -label:verification-found $NOT_TEAM_MEMBERS"
161166
},
162167
{
163168
"kind": 1,

0 commit comments

Comments
 (0)