Merge pull request microsoft#269665 from mjbvz/dev/mjbvz/delicious-sloth

Add lint rule for `as any` and bulk ignore all existing breaks

Author: mjbvz

.eslint-plugin-local/code-no-any-casts.ts

@@ -0,0 +1,21 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as eslint from 'eslint';
+import { TSESTree } from '@typescript-eslint/utils';
+
+export = new class NoAnyCasts implements eslint.Rule.RuleModule {
+
+	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
+		return {
+			'TSTypeAssertion[typeAnnotation.type="TSAnyKeyword"], TSAsExpression[typeAnnotation.type="TSAnyKeyword"]': (node: TSESTree.TSTypeAssertion | TSESTree.TSAsExpression) => {
+				context.report({
+					node,
+					message: `Avoid casting to 'any' type. Consider using a more specific type or type guards for better type safety.`
+				});
+			}
+		};
+	}
+};

.eslint-plugin-local/code-no-observable-get-in-reactive-context.ts

@@ -61,10 +61,12 @@ function checkFunctionForObservableGetCalls(
 		if (node.type === 'CallExpression' && isObservableGetCall(node)) {
 			// Flag .get() calls since we're always in a reactive context here
 			context.report({
+				// eslint-disable-next-line local/code-no-any-casts
 				node: node as any as ESTree.Node,
 				message: `Observable '.get()' should not be used in reactive context. Use '.read(${readerName})' instead to properly track dependencies or '.read(undefined)' to be explicit about an untracked read.`,
 				fix: (fixer) => {
 					const memberExpression = node.callee as TSESTree.MemberExpression;
+					// eslint-disable-next-line local/code-no-any-casts
 					return fixer.replaceText(node as any, `${context.getSourceCode().getText(memberExpression.object as any)}.read(undefined)`);
 				}
 			});
@@ -131,6 +133,7 @@ function isReactiveFunctionWithReader(callee: TSESTree.Node): boolean {
 function walkChildren(node: TSESTree.Node, cb: (child: TSESTree.Node) => void) {
 	const keys = visitorKeys.KEYS[node.type] || [];
 	for (const key of keys) {
+		// eslint-disable-next-line local/code-no-any-casts
 		const child = (node as any)[key];
 		if (Array.isArray(child)) {
 			for (const item of child) {

.eslint-plugin-local/code-no-reader-after-await.ts

@@ -59,6 +59,7 @@ function checkFunctionForAwaitBeforeReader(
 			if (awaitPositions.length > 0) {
 				const methodName = getMethodName(node);
 				context.report({
+					// eslint-disable-next-line local/code-no-any-casts
 					node: node as any as ESTree.Node,
 					message: `Reader method '${methodName}' should not be called after 'await'. The reader becomes invalid after async operations.`
 				});

.eslint-plugin-local/code-no-static-self-ref.ts

@@ -33,6 +33,7 @@ export = new class implements eslint.Rule.RuleModule {
 			}
 
 			const name = classDeclaration.id.name;
+			// eslint-disable-next-line local/code-no-any-casts
 			const valueText = context.sourceCode.getText(<any>propertyDefinition.value);
 
 			if (valueText.includes(name + '.')) {

.eslint-plugin-local/code-no-test-async-suite.ts

@@ -20,6 +20,7 @@ export = new class NoAsyncSuite implements eslint.Rule.RuleModule {
 		function hasAsyncSuite(node: any) {
 			if (isCallExpression(node) && node.arguments.length >= 2 && isFunctionExpression(node.arguments[1]) && node.arguments[1].async) {
 				return context.report({
+					// eslint-disable-next-line local/code-no-any-casts
 					node: node as any,
 					message: 'suite factory function should never be async'
 				});

.eslint-plugin-local/code-no-unexternalized-strings.ts

@@ -81,6 +81,7 @@ export = new class NoUnexternalizedStrings implements eslint.Rule.RuleModule {
 				context.report({
 					loc: messageNode.loc,
 					messageId: 'badMessage',
+					// eslint-disable-next-line local/code-no-any-casts
 					data: { message: context.getSourceCode().getText(<any>node) }
 				});
 			}
@@ -128,6 +129,7 @@ export = new class NoUnexternalizedStrings implements eslint.Rule.RuleModule {
 				// report all invalid duplicates (same key, different message)
 				if (values.length > 1) {
 					for (let i = 1; i < values.length; i++) {
+						// eslint-disable-next-line local/code-no-any-casts
 						if (context.getSourceCode().getText(<any>values[i - 1].message) !== context.getSourceCode().getText(<any>values[i].message)) {
 							context.report({ loc: values[i].call.loc, messageId: 'duplicateKey', data: { key } });
 						}

.eslint-plugin-local/vscode-dts-provider-naming.ts

@@ -32,6 +32,7 @@ export = new class ApiProviderNaming implements eslint.Rule.RuleModule {
 					return;
 				}
 
+				// eslint-disable-next-line local/code-no-any-casts
 				const methodName = (<any>(<TSESTree.TSMethodSignatureNonComputedName>node).key).name;
 
 				if (!ApiProviderNaming._providerFunctionNames.test(methodName)) {

.eslint-plugin-local/vscode-dts-vscode-in-comments.ts

@@ -40,7 +40,9 @@ export = new class ApiVsCodeInComments implements eslint.Rule.RuleModule {
 						}
 
 						// Types for eslint seem incorrect
+						// eslint-disable-next-line local/code-no-any-casts
 						const start = sourceCode.getLocFromIndex(startIndex + match.index) as any as estree.Position;
+						// eslint-disable-next-line local/code-no-any-casts
 						const end = sourceCode.getLocFromIndex(startIndex + match.index + match[0].length) as any as estree.Position;
 						context.report({
 							messageId: 'comment',

build/azure-pipelines/common/publish.js

@@ -521,6 +521,7 @@ class ESRPReleaseService {
 				// Release service uses hex format, not base64url :roll_eyes:
 				x5t: getThumbprint(this.requestSigningCertificates[0], 'sha1').toString('hex'),
 				// Release service uses a '.' separated string, not an array of strings :roll_eyes:
+				// eslint-disable-next-line local/code-no-any-casts
 				x5c: this.requestSigningCertificates.map(c => getCertificateBuffer(c).toString('base64url')).join('.') as any,
 			},
 			payload: message,