debt - start to reduce explicit any in my code (microsoft#269479)

Author: bpasero

eslint.config.js

@@ -177,6 +177,93 @@ export default tseslint.config(
 			]
 		}
 	},
+	// vscode TS: strict no explicit `any`
+	{
+		files: [
+			'src/vs/base/common/extpath.ts',
+			'src/vs/base/common/glob.ts',
+			'src/vs/base/common/path.ts',
+			'src/vs/base/common/stream.ts',
+			'src/vs/base/node/pfs.ts',
+			'src/vs/base/parts/contextmenu/**',
+			// 'src/vs/base/parts/ipc/**',
+			// 'src/vs/base/parts/sandbox/**',
+			'src/vs/base/parts/storage/**',
+			'src/vs/platform/auxiliaryWindow/**',
+			// 'src/vs/platform/backup/**',
+			// 'src/vs/platform/editor/**',
+			// 'src/vs/platform/environment/**',
+			// 'src/vs/platform/files/**',
+			// 'src/vs/platform/ipc/**',
+			// 'src/vs/platform/launch/**',
+			// 'src/vs/platform/lifecycle/**',
+			// 'src/vs/platform/menubar/**',
+			// 'src/vs/platform/native/**',
+			// 'src/vs/platform/sharedProcess/**',
+			// 'src/vs/platform/state/**',
+			// 'src/vs/platform/storage/**',
+			// 'src/vs/platform/utilityProcess/**',
+			// 'src/vs/platform/window/**',
+			// 'src/vs/platform/windows/**',
+			// 'src/vs/platform/workspace/**',
+			// 'src/vs/platform/workspaces/**',
+			'src/bootstrap-cli.ts',
+			'src/bootstrap-esm.ts',
+			'src/bootstrap-fork.ts',
+			'src/bootstrap-import.ts',
+			'src/bootstrap-meta.ts',
+			'src/bootstrap-node.ts',
+			'src/bootstrap-server.ts',
+			'src/cli.ts',
+			'src/main.ts',
+			'src/server-cli.ts',
+			'src/server-main.ts',
+			'src/vs/code/**',
+			'src/vs/workbench/services/activity/**',
+			'src/vs/workbench/services/auxiliaryWindow/**',
+			'src/vs/workbench/services/chat/**',
+			'src/vs/workbench/services/contextmenu/**',
+			'src/vs/workbench/services/dialogs/**',
+			'src/vs/workbench/services/editor/**',
+			// 'src/vs/workbench/services/environment/**',
+			'src/vs/workbench/services/files/**',
+			'src/vs/workbench/services/filesConfiguration/**',
+			'src/vs/workbench/services/history/**',
+			'src/vs/workbench/services/host/**',
+			'src/vs/workbench/services/label/**',
+			'src/vs/workbench/services/layout/**',
+			'src/vs/workbench/services/lifecycle/**',
+			'src/vs/workbench/services/notification/**',
+			'src/vs/workbench/services/path/**',
+			'src/vs/workbench/services/progress/**',
+			// 'src/vs/workbench/services/storage/**',
+			// 'src/vs/workbench/services/textfile/**',
+			// 'src/vs/workbench/services/textmodelResolver/**',
+			// 'src/vs/workbench/services/untitled/**',
+			// 'src/vs/workbench/services/utilityProcess/**',
+			// 'src/vs/workbench/services/views/**',
+			// 'src/vs/workbench/services/workingCopy/**',
+			// 'src/vs/workbench/services/workspaces/**',
+			// 'src/vs/workbench/common/**',
+			// 'src/vs/workbench/browser/**',
+			// 'src/vs/workbench/electron-browser/**',
+			// 'src/vs/workbench/contrib/files/**',
+		],
+		languageOptions: {
+			parser: tseslint.parser,
+		},
+		plugins: {
+			'@typescript-eslint': tseslint.plugin,
+		},
+		rules: {
+			'@typescript-eslint/no-explicit-any': [
+				'warn',
+				{
+					'ignoreRestArgs': false
+				}
+			]
+		}
+	},
 	// Tests
 	{
 		files: [

src/bootstrap-import.ts

@@ -47,7 +47,7 @@ export async function initialize(injectPath: string): Promise<void> {
 	console.log(`[bootstrap-import] Initialized node_modules redirector for: ${injectPath}`);
 }
 
-export async function resolve(specifier: string | number, context: any, nextResolve: (arg0: any, arg1: any) => any) {
+export async function resolve(specifier: string | number, context: unknown, nextResolve: (arg0: unknown, arg1: unknown) => unknown) {
 
 	const newSpecifier = _specifierToUrl[specifier];
 	if (newSpecifier !== undefined) {

src/bootstrap-node.ts

@@ -83,7 +83,7 @@ export function removeGlobalNodeJsModuleLookupPaths(): void {
 
 	const originalResolveLookupPaths = Module._resolveLookupPaths;
 
-	Module._resolveLookupPaths = function (moduleName: string, parent: any): string[] {
+	Module._resolveLookupPaths = function (moduleName: string, parent: unknown): string[] {
 		const paths = originalResolveLookupPaths(moduleName, parent);
 		if (Array.isArray(paths)) {
 			let commonSuffixLength = 0;

src/main.ts

@@ -582,8 +582,7 @@ function registerListeners(): void {
 	 * the app-ready event. We listen very early for open-file and remember this upon startup as path to open.
 	 */
 	const macOpenFiles: string[] = [];
-	// eslint-disable-next-line local/code-no-any-casts
-	(globalThis as any)['macOpenFiles'] = macOpenFiles;
+	(globalThis as { macOpenFiles?: string[] }).macOpenFiles = macOpenFiles;
 	app.on('open-file', function (event, path) {
 		macOpenFiles.push(path);
 	});
@@ -603,8 +602,7 @@ function registerListeners(): void {
 		app.on('open-url', onOpenUrl);
 	});
 
-	// eslint-disable-next-line local/code-no-any-casts
-	(globalThis as any)['getOpenUrls'] = function () {
+	(globalThis as { getOpenUrls?: () => string[] }).getOpenUrls = function () {
 		app.removeListener('open-url', onOpenUrl);
 
 		return openUrls;

src/server-main.ts

@@ -20,8 +20,7 @@ import { INLSConfiguration } from './vs/nls.js';
 import { IServerAPI } from './vs/server/node/remoteExtensionHostAgentServer.js';
 
 perf.mark('code/server/start');
-// eslint-disable-next-line local/code-no-any-casts
-(globalThis as any).vscodeServerStartTime = performance.now();
+(globalThis as { vscodeServerStartTime?: number }).vscodeServerStartTime = performance.now();
 
 // Do a quick parse to determine if a server or the cli needs to be started
 const parsedArgs = minimist(process.argv.slice(2), {
@@ -139,8 +138,7 @@ if (shouldSpawnCli) {
 		console.log(output);
 
 		perf.mark('code/server/started');
-		// eslint-disable-next-line local/code-no-any-casts
-		(globalThis as any).vscodeServerListenTime = performance.now();
+		(globalThis as { vscodeServerListenTime?: number }).vscodeServerListenTime = performance.now();
 
 		await getRemoteExtensionHostAgentServer();
 	});
@@ -153,7 +151,7 @@ if (shouldSpawnCli) {
 	});
 }
 
-function sanitizeStringArg(val: any): string | undefined {
+function sanitizeStringArg(val: unknown): string | undefined {
 	if (Array.isArray(val)) { // if an argument is passed multiple times, minimist creates an array
 		val = val.pop(); // take the last item
 	}

src/vs/base/common/stream.ts

@@ -331,14 +331,14 @@ class WriteableStreamImpl<T> implements WriteableStream<T> {
 	on(event: 'data', callback: (data: T) => void): void;
 	on(event: 'error', callback: (err: Error) => void): void;
 	on(event: 'end', callback: () => void): void;
-	on(event: 'data' | 'error' | 'end', callback: (arg0?: any) => void): void {
+	on(event: 'data' | 'error' | 'end', callback: ((data: T) => void) | ((err: Error) => void) | (() => void)): void {
 		if (this.state.destroyed) {
 			return;
 		}
 
 		switch (event) {
 			case 'data':
-				this.listeners.data.push(callback);
+				this.listeners.data.push(callback as (data: T) => void);
 
 				// switch into flowing mode as soon as the first 'data'
 				// listener is added and we are not yet in flowing mode
@@ -347,7 +347,7 @@ class WriteableStreamImpl<T> implements WriteableStream<T> {
 				break;
 
 			case 'end':
-				this.listeners.end.push(callback);
+				this.listeners.end.push(callback as () => void);
 
 				// emit 'end' event directly if we are flowing
 				// and the end has already been reached
@@ -360,7 +360,7 @@ class WriteableStreamImpl<T> implements WriteableStream<T> {
 				break;
 
 			case 'error':
-				this.listeners.error.push(callback);
+				this.listeners.error.push(callback as (err: Error) => void);
 
 				// emit buffered 'error' events unless done already
 				// now that we know that we have at least one listener

src/vs/base/parts/contextmenu/electron-browser/contextmenu.ts

@@ -13,13 +13,16 @@ export function popup(items: IContextMenuItem[], options?: IPopupOptions, onHide
 
 	const contextMenuId = contextMenuIdPool++;
 	const onClickChannel = `vscode:onContextMenu${contextMenuId}`;
-	const onClickChannelHandler = (event: unknown, itemId: number, context: IContextMenuEvent) => {
+	const onClickChannelHandler = (_event: unknown, ...args: unknown[]) => {
+		const itemId = args[0] as number;
+		const context = args[1] as IContextMenuEvent;
 		const item = processedItems[itemId];
 		item.click?.(context);
 	};
 
 	ipcRenderer.once(onClickChannel, onClickChannelHandler);
-	ipcRenderer.once(CONTEXT_MENU_CLOSE_CHANNEL, (event: unknown, closedContextMenuId: number) => {
+	ipcRenderer.once(CONTEXT_MENU_CLOSE_CHANNEL, (_event: unknown, ...args: unknown[]) => {
+		const closedContextMenuId = args[0] as number;
 		if (closedContextMenuId !== contextMenuId) {
 			return;
 		}

src/vs/base/parts/sandbox/electron-browser/electronTypes.ts

@@ -66,17 +66,17 @@ export interface IpcRenderer {
 	 * returned by `invoke` will reject. However, the `Error` object in the renderer
 	 * process will not be the same as the one thrown in the main process.
 	 */
-	invoke(channel: string, ...args: any[]): Promise<any>;
+	invoke(channel: string, ...args: unknown[]): Promise<unknown>;
 	/**
 	 * Listens to `channel`, when a new message arrives `listener` would be called with
 	 * `listener(event, args...)`.
 	 */
-	on(channel: string, listener: (event: IpcRendererEvent, ...args: any[]) => void): this;
+	on(channel: string, listener: (event: IpcRendererEvent, ...args: unknown[]) => void): this;
 	/**
 	 * Adds a one time `listener` function for the event. This `listener` is invoked
 	 * only the next time a message is sent to `channel`, after which it is removed.
 	 */
-	once(channel: string, listener: (event: IpcRendererEvent, ...args: any[]) => void): this;
+	once(channel: string, listener: (event: IpcRendererEvent, ...args: unknown[]) => void): this;
 	// Note: API with `Transferable` intentionally commented out because you
 	// cannot transfer these when `contextIsolation: true`.
 	// /**
@@ -92,12 +92,12 @@ export interface IpcRenderer {
 	//  * For more information on using `MessagePort` and `MessageChannel`, see the MDN
 	//  * documentation.
 	//  */
-	// postMessage(channel: string, message: any, transfer?: MessagePort[]): void;
+	// postMessage(channel: string, message: unknown, transfer?: MessagePort[]): void;
 	/**
 	 * Removes the specified `listener` from the listener array for the specified
 	 * `channel`.
 	 */
-	removeListener(channel: string, listener: (event: IpcRendererEvent, ...args: any[]) => void): this;
+	removeListener(channel: string, listener: (event: IpcRendererEvent, ...args: unknown[]) => void): this;
 	/**
 	 * Send an asynchronous message to the main process via `channel`, along with
 	 * arguments. Arguments will be serialized with the Structured Clone Algorithm,
@@ -122,7 +122,7 @@ export interface IpcRenderer {
 	 * If you want to receive a single response from the main process, like the result
 	 * of a method call, consider using `ipcRenderer.invoke`.
 	 */
-	send(channel: string, ...args: any[]): void;
+	send(channel: string, ...args: unknown[]): void;
 }
 
 export interface WebFrame {

src/vs/base/parts/sandbox/electron-browser/globals.ts

@@ -115,8 +115,18 @@ export interface ISandboxContext {
 	resolveConfiguration(): Promise<ISandboxConfiguration>;
 }
 
-// eslint-disable-next-line local/code-no-any-casts
-const vscodeGlobal = (globalThis as any).vscode;
+interface ISandboxGlobal {
+	vscode: {
+		readonly ipcRenderer: IpcRenderer;
+		readonly ipcMessagePort: IpcMessagePort;
+		readonly webFrame: WebFrame;
+		readonly process: ISandboxNodeProcess;
+		readonly context: ISandboxContext;
+		readonly webUtils: WebUtils;
+	};
+}
+
+const vscodeGlobal = (globalThis as unknown as ISandboxGlobal).vscode;
 export const ipcRenderer: IpcRenderer = vscodeGlobal.ipcRenderer;
 export const ipcMessagePort: IpcMessagePort = vscodeGlobal.ipcMessagePort;
 export const webFrame: WebFrame = vscodeGlobal.webFrame;

src/vs/base/parts/sandbox/electron-browser/preload-aux.ts

@@ -23,13 +23,13 @@
 		 */
 		ipcRenderer: {
 
-			send(channel: string, ...args: any[]): void {
+			send(channel: string, ...args: unknown[]): void {
 				if (validateIPC(channel)) {
 					ipcRenderer.send(channel, ...args);
 				}
 			},
 
-			invoke(channel: string, ...args: any[]): Promise<any> {
+			invoke(channel: string, ...args: unknown[]): Promise<unknown> {
 				validateIPC(channel);
 
 				return ipcRenderer.invoke(channel, ...args);