Skip to content

Commit 951d731

Browse files
committed
remove pause action from chat view
fixes microsoft#252271
1 parent 55e0109 commit 951d731

5 files changed

Lines changed: 2 additions & 57 deletions

File tree

src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -277,45 +277,6 @@ class ToggleChatModeAction extends Action2 {
277277
}
278278
}
279279

280-
export const ToggleRequestPausedActionId = 'workbench.action.chat.toggleRequestPaused';
281-
export class ToggleRequestPausedAction extends Action2 {
282-
static readonly ID = ToggleRequestPausedActionId;
283-
284-
constructor() {
285-
super({
286-
id: ToggleRequestPausedAction.ID,
287-
title: localize2('interactive.toggleRequestPausd.label', "Toggle Request Paused"),
288-
category: CHAT_CATEGORY,
289-
icon: Codicon.debugPause,
290-
toggled: {
291-
condition: ChatContextKeys.isRequestPaused,
292-
icon: Codicon.play,
293-
tooltip: localize('requestIsPaused', "Resume Request"),
294-
},
295-
tooltip: localize('requestNotPaused', "Pause Request"),
296-
menu: [
297-
{
298-
id: MenuId.ChatExecute,
299-
order: 3.5,
300-
when: ContextKeyExpr.and(
301-
ChatContextKeys.canRequestBePaused,
302-
ChatContextKeys.chatModeKind.isEqualTo(ChatModeKind.Agent),
303-
ChatContextKeys.location.isEqualTo(ChatAgentLocation.Panel),
304-
ContextKeyExpr.or(ChatContextKeys.isRequestPaused.negate(), ChatContextKeys.inputHasText.negate()),
305-
),
306-
group: 'navigation',
307-
}]
308-
});
309-
}
310-
311-
override run(accessor: ServicesAccessor, ...args: any[]): void {
312-
const context: IChatExecuteActionContext | undefined = args[0];
313-
const widgetService = accessor.get(IChatWidgetService);
314-
const widget = context?.widget ?? widgetService.lastFocusedWidget;
315-
widget?.togglePaused();
316-
}
317-
}
318-
319280
class SwitchToNextModelAction extends Action2 {
320281
static readonly ID = 'workbench.action.chat.switchToNextModel';
321282

@@ -925,7 +886,6 @@ export function registerChatExecuteActions() {
925886
registerAction2(ChatSubmitWithCodebaseAction);
926887
registerAction2(CreateRemoteAgentJobAction);
927888
registerAction2(ToggleChatModeAction);
928-
registerAction2(ToggleRequestPausedAction);
929889
registerAction2(SwitchToNextModelAction);
930890
registerAction2(OpenModelPickerAction);
931891
registerAction2(OpenModePickerAction);

src/vs/workbench/contrib/chat/browser/chat.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,6 @@ export interface IChatWidget {
226226
*/
227227
waitForReady(): Promise<void>;
228228
getViewState(): IChatViewState;
229-
togglePaused(): void;
230229
lockToCodingAgent(name: string, displayName: string): void;
231230

232231
delegateScrollFromMouseWheelEvent(event: IMouseWheelEvent): void;

src/vs/workbench/contrib/chat/browser/chatWidget.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1487,10 +1487,6 @@ export class ChatWidget extends Disposable implements IChatWidget {
14871487
this.container.style.setProperty('--vscode-chat-list-background', this.themeService.getColorTheme().getColor(this.styles.listBackground)?.toString() ?? '');
14881488
}
14891489

1490-
togglePaused() {
1491-
this.viewModel?.model.toggleLastRequestPaused();
1492-
this.onDidChangeItems();
1493-
}
14941490

14951491
setModel(model: IChatModel, viewState: IChatViewState): void {
14961492
if (!this.container) {

src/vs/workbench/contrib/chat/browser/media/chat.css

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,9 +1055,7 @@ have to be updated for changes to the rules above, or to support more deeply nes
10551055
}
10561056
}
10571057

1058-
.chat-execute-toolbar .codicon.codicon-debug-pause {
1059-
color: var(--vscode-icon-foreground) !important;
1060-
}
1058+
10611059

10621060
.interactive-session .chat-input-toolbars .chat-modelPicker-item .action-label {
10631061
height: 16px;

src/vs/workbench/contrib/chat/common/chatModel.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -973,7 +973,6 @@ export interface IChatModel extends IDisposable {
973973
readonly inputPlaceholder?: string;
974974
readonly editingSessionObs?: ObservablePromise<IChatEditingSession> | undefined;
975975
readonly editingSession?: IChatEditingSession | undefined;
976-
toggleLastRequestPaused(paused?: boolean): void;
977976
/**
978977
* Sets requests as 'disabled', removing them from the UI. If a request ID
979978
* is given without undo stops, it's removed entirely. If an undo stop
@@ -1502,14 +1501,7 @@ export class ChatModel extends Disposable implements IChatModel {
15021501
};
15031502
}
15041503

1505-
toggleLastRequestPaused(isPaused?: boolean) {
1506-
if (this.requestPausibility !== ChatPauseState.NotPausable && this.lastRequest?.response?.agent) {
1507-
const pausedValue = isPaused ?? !this.lastRequest.response.isPaused.get();
1508-
this.lastRequest.response.setPaused(pausedValue);
1509-
this.chatAgentService.setRequestPaused(this.lastRequest.response.agent.id, this.lastRequest.id, pausedValue);
1510-
this._onDidChange.fire({ kind: 'changedRequest', request: this.lastRequest });
1511-
}
1512-
}
1504+
15131505

15141506
getRequests(): ChatRequestModel[] {
15151507
return this._requests;

0 commit comments

Comments
 (0)