Skip to content

Commit d3c3cf8

Browse files
Attempt to fix Codespaces bug by declaring a default (microsoft#261484)
Fixes microsoft#261238
1 parent 137f939 commit d3c3cf8

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

extensions/github-authentication/src/extension.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,11 @@ export function activate(context: vscode.ExtensionContext) {
8181
}));
8282

8383
// Listener to prompt for reload when the fetch implementation setting changes
84-
let beforeFetchSetting = vscode.workspace.getConfiguration('github-authentication').get<boolean>('useElectronFetch');
84+
const beforeFetchSetting = vscode.workspace.getConfiguration().get<boolean>('github-authentication.useElectronFetch', true);
8585
context.subscriptions.push(vscode.workspace.onDidChangeConfiguration(async e => {
8686
if (e.affectsConfiguration('github-authentication.useElectronFetch')) {
87-
const afterFetchSetting = vscode.workspace.getConfiguration('github-authentication').get<boolean>('useElectronFetch');
87+
const afterFetchSetting = vscode.workspace.getConfiguration().get<boolean>('github-authentication.useElectronFetch', true);
8888
if (beforeFetchSetting !== afterFetchSetting) {
89-
beforeFetchSetting = afterFetchSetting;
9089
const selection = await vscode.window.showInformationMessage(
9190
vscode.l10n.t('GitHub Authentication - Reload required'),
9291
{

0 commit comments

Comments
 (0)