Skip to content

Commit ee242eb

Browse files
committed
improve ui and logs
1 parent 2d40822 commit ee242eb

7 files changed

Lines changed: 46 additions & 260 deletions

File tree

packages/react-router-devtools/src/client/components/Checkbox.tsx

Lines changed: 0 additions & 35 deletions
This file was deleted.

packages/react-router-devtools/src/client/components/NewRouteForm.tsx

Lines changed: 0 additions & 169 deletions
This file was deleted.

packages/react-router-devtools/src/client/components/icon/Icon.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export const Icon = ({ name, title, testId, className, size = "sm", ...props }:
3737
const isStrokeIcon = strokeIcon.includes(name)
3838
const iconClasses = cx(styles.icon.base, className, isEmptyFill && styles.icon.fillTransparent)
3939
return (
40+
// biome-ignore lint/a11y/noSvgWithoutTitle: i don't want titles on hover
4041
<svg
4142
className={iconClasses}
4243
fill={isEmptyFill ? "none" : "currentColor"}
@@ -47,7 +48,6 @@ export const Icon = ({ name, title, testId, className, size = "sm", ...props }:
4748
data-name={name}
4849
{...props}
4950
>
50-
<title>{title ?? name}</title>
5151
<defs>
5252
<symbol
5353
id="Layout"

packages/react-router-devtools/src/client/layout/Tabs.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ const Tab = ({
2626
const { styles } = useStyles()
2727

2828
return (
29-
// biome-ignore lint/a11y/useKeyWithClickEvents: ignored
30-
<div
29+
<button
3130
data-testid={tab.id}
3231
onClick={() => (onClick ? onClick() : setSettings({ activeTab: tab.id as TabsType }))}
3332
title={typeof tab.name === "string" ? tab.name : undefined}
33+
type="button"
3434
className={cx(
3535
"group",
3636
styles.layout.tabs.tab,
@@ -39,7 +39,7 @@ const Tab = ({
3939
)}
4040
>
4141
<div className={cx(className, styles.layout.tabs.tabIcon)}>{tab.icon}</div>
42-
</div>
42+
</button>
4343
)
4444
}
4545

0 commit comments

Comments
 (0)