refactor: wip

Author: BioPhoton

e2e/plugin-knip-e2e/tests/knip-reporter.e2e.test.ts

@@ -44,8 +44,7 @@ describe('knip reporter for code pushup audits', () => {
         'knip',
         '--no-exit-code',
         `--reporter=${reporterPath}`,
-        /* eslint-disable-next-line unicorn/prefer-string-raw */
-        `--reporter-options={\\"outputFile\\":\\"knip-report.json\\"}`,
+        `--reporter-options=${JSON.stringify(JSON.stringify({ outputFile: 'knip-report.json' }))}`,
       ],
       cwd: reporterSetupDir,
     });
@@ -66,7 +65,7 @@ describe('knip reporter for code pushup audits', () => {
                 message: 'Unused dependency zod',
                 severity: 'error',
                 source: {
-                  file: expect.stringContaining('package.json'),
+                  file: expect.pathToEndWith('package.json'),
                   position: {
                     startColumn: 6,
                     startLine: 4,

e2e/plugin-knip-e2e/tsconfig.test.json

@@ -9,6 +9,7 @@
     "vitest.e2e.config.ts",
     "tests/**/*.e2e.test.ts",
     "tests/**/*.d.ts",
-    "mocks/**/*.ts"
+    "mocks/**/*.ts",
+    "../../testing/test-setup/src/vitest.d.ts"
   ]
 }

packages/plugin-knip/src/lib/reporter/reporter.unit.test.ts

@@ -123,60 +123,59 @@ describe('knipReporter', () => {
                 'jsonc-eslint-parser': {
                     type: 'unlisted',
                     symbol: 'jsonc-eslint-parser',
-                    filePath: expect.stringContaining('package.json')
+                    filePath: expect.pathToEndWith('package.json')
                 },
             },
         });
         expect(rawKnipReport.counters).toStrictEqual({files: 1, unlisted: 1});
     });
-});
 
-it('should log if custom reporter option verbose is true', async () => {
-    const reporterOptions: CustomReporterOptions = {
-        verbose: true,
-        outputFile: KNIP_REPORT_NAME,
-        rawOutputFile: KNIP_RAW_REPORT_NAME,
-    };
-    await expect(
-        knipReporter({
-            report: {files: true},
-            issues: {files: new Set(['main.js'])},
-            options: JSON.stringify(reporterOptions),
-        } as ReporterOptions),
-    ).resolves.toBeUndefined();
-
-    expect(logger.info).toHaveBeenCalledTimes(3);
-    expect(logger.info).toHaveBeenNthCalledWith(
-        1,
-        `Reporter called with options: ${JSON.stringify(
-            reporterOptions,
-            null,
+    it('should log if custom reporter option verbose is true', async () => {
+        const reporterOptions: CustomReporterOptions = {
+            verbose: true,
+            outputFile: KNIP_REPORT_NAME,
+            rawOutputFile: KNIP_RAW_REPORT_NAME,
+        };
+        await expect(
+            knipReporter({
+                report: {files: true},
+                issues: {files: new Set(['main.js'])},
+                options: JSON.stringify(reporterOptions),
+            } as ReporterOptions),
+        ).resolves.toBeUndefined();
+
+        expect(logger.info).toHaveBeenCalledTimes(3);
+        expect(logger.info).toHaveBeenNthCalledWith(
+            1,
+            `Reporter called with options: ${JSON.stringify(
+                reporterOptions,
+                null,
+                2,
+            )}`,
+        );
+        expect(logger.info).toHaveBeenNthCalledWith(
             2,
-        )}`,
-    );
-    expect(logger.info).toHaveBeenNthCalledWith(
-        2,
-        `Saved raw report to ${reporterOptions.rawOutputFile}`,
-    );
-    expect(logger.info).toHaveBeenNthCalledWith(
-        3,
-        `Saved report to ${reporterOptions.outputFile}`,
-    );
-});
+            `Saved raw report to ${reporterOptions.rawOutputFile}`,
+        );
+        expect(logger.info).toHaveBeenNthCalledWith(
+            3,
+            `Saved report to ${reporterOptions.outputFile}`,
+        );
+    });
 
-it('should produce valid audit outputs', async () => {
-    await expect(
-        knipReporter(rawReport as ReporterOptions),
-    ).resolves.toBeUndefined();
-
-    const auditOutputsContent = await memfsFs.promises.readFile(
-        'knip-report.json',
-        {encoding: 'utf8'},
-    );
-    const auditOutputsJson = JSON.parse(
-        auditOutputsContent.toString(),
-    ) as AuditOutputs;
-    expect(auditOutputsJson).toMatchSnapshot();
-});
+    it('should produce valid audit outputs', async () => {
+        await expect(
+            knipReporter(rawReport as ReporterOptions),
+        ).resolves.toBeUndefined();
+
+        const auditOutputsContent = await memfsFs.promises.readFile(
+            'knip-report.json',
+            {encoding: 'utf8'},
+        );
+        const auditOutputsJson = JSON.parse(
+            auditOutputsContent.toString(),
+        ) as AuditOutputs;
+        expect(auditOutputsJson).toMatchSnapshot();
+    })
 })
-;
+

packages/plugin-knip/tsconfig.test.json

@@ -12,6 +12,7 @@
     "src/**/*.test.tsx",
     "src/**/*.test.js",
     "src/**/*.test.jsx",
-    "src/**/*.d.ts"
+    "src/**/*.d.ts",
+    "../../testing/test-setup/src/vitest.d.ts"
   ]
 }