feat: retry requests on 502 responses (#382)

Author: joseph-sentry

codecov_cli/helpers/request.py

@@ -47,15 +47,27 @@ def backoff_time(curr_retry):
     return 2 ** (curr_retry - 1)
 
 
+class RetryException(Exception):
+    ...
+
+
 def retry_request(func):
     def wrapper(*args, **kwargs):
         retry = 0
         while retry < MAX_RETRIES:
             try:
-                return func(*args, **kwargs)
+                response = func(*args, **kwargs)
+                if response.status_code == 502:
+                    logger.warning(
+                        "Response status code was 502.",
+                        extra=dict(extra_log_attributes=dict(retry=retry)),
+                    )
+                    raise RetryException
+                return response
             except (
                 requests.exceptions.ConnectionError,
                 requests.exceptions.Timeout,
+                RetryException,
             ) as exp:
                 logger.warning(
                     "Request failed. Retrying",

tests/helpers/test_upload_sender.py

@@ -1,4 +1,5 @@
 import json
+import re
 from pathlib import Path
 
 import pytest
@@ -304,6 +305,23 @@ def test_upload_sender_result_fail_post_400(
 
         assert sender.warnings is not None
 
+    def test_upload_sender_result_fail_post_502(
+        self, mocker, mocked_responses, mocked_legacy_upload_endpoint, capsys
+    ):
+        mocker.patch("codecov_cli.helpers.request.sleep")
+        mocked_legacy_upload_endpoint.status = 502
+
+        with pytest.raises(Exception, match="Request failed after too many retries"):
+            _ = UploadSender().send_upload_data(
+                upload_collection, random_sha, random_token, **named_upload_data
+            )
+
+        matcher = re.compile(
+            r"(warning.*((Response status code was 502)|(Request failed\. Retrying)).*(\n)?){6}"
+        )
+
+        assert matcher.match(capsys.readouterr().err) is not None
+
     def test_upload_sender_result_fail_put_400(
         self, mocked_responses, mocked_legacy_upload_endpoint, mocked_storage_server
     ):