address nitpicks

Signed-off-by: Taylor Silva <dev@taydev.net>

Author: taylorsilva

out_command.go

@@ -49,9 +49,7 @@ func (c *OutCommand) Run(sourceDir string, request OutRequest) (OutResponse, err
 	}
 
 	var targetCommitish string
-	commitishSpecified := false
 	if request.Params.CommitishPath != "" {
-		commitishSpecified = true
 		targetCommitish, err = c.fileContents(filepath.Join(sourceDir, request.Params.CommitishPath))
 		if err != nil {
 			return OutResponse{}, err
@@ -99,10 +97,8 @@ func (c *OutCommand) Run(sourceDir string, request OutRequest) (OutResponse, err
 		existingRelease.Draft = github.Bool(draft)
 		existingRelease.Prerelease = github.Bool(prerelease)
 
-		if commitishSpecified {
+		if targetCommitish != "" {
 			existingRelease.TargetCommitish = github.String(targetCommitish)
-		} else {
-			existingRelease.TargetCommitish = nil
 		}
 
 		if bodySpecified {

out_command_test.go

@@ -185,7 +185,7 @@ var _ = Describe("Out Command", func() {
 		})
 
 		Context("when a commitish is not supplied", func() {
-			It("does not update the target commitish", func() {
+			It("updates the existing release", func() {
 				_, err := command.Run(sourcesDir, request)
 				Ω(err).ShouldNot(HaveOccurred())
 
@@ -194,7 +194,7 @@ var _ = Describe("Out Command", func() {
 				updatedRelease := githubClient.UpdateReleaseArgsForCall(0)
 				Ω(*updatedRelease.Name).Should(Equal("v0.3.12"))
 				Ω(*updatedRelease.Body).Should(Equal("this is a great release"))
-				Ω(updatedRelease.TargetCommitish).Should(BeNil())
+				Ω(updatedRelease.TargetCommitish).Should(BeNil(), "does not set the TargetCommitish")
 			})
 		})