Fix comparison of children in graph generation

Replace the URI comparison with pointer comparison, this removes all
allocations during the children comparison. The register already
guarantees that multiple URIs are not registered.

Change the ordering of the comparison first check the most likely
filter and do the set check last.

Signed-off-by: Derek McGowan <derek@mcg.dev>

Author: dmcgowan

plugin.go

@@ -135,7 +135,7 @@ func (registry Registry) Graph(filter DisableFilter) []Registration {
 func children(reg *Registration, registry []*Registration, added, disabled map[*Registration]bool, ordered *[]Registration) {
 	for _, t := range reg.Requires {
 		for _, r := range registry {
-			if !disabled[r] && r.URI() != reg.URI() && (t == "*" || r.Type == t) {
+			if (t == "*" || r.Type == t) && r != reg && !disabled[r] {
 				children(r, registry, added, disabled, ordered)
 				if !added[r] {
 					*ordered = append(*ordered, *r)