(int) is not lambda call

Author: aadanen

lib/checkleakautovar.cpp

@@ -282,7 +282,17 @@ static const Token * isFunctionCall(const Token * nameToken)
 static const Token * isAnonymousFunctionCall(const Token * tok)
 {
     // match one of the supported LHS patterns
-    if (tok->previous()->str() == "(" && !tok->previous()->isBinaryOp() && tok->linkAt(-1)) {
+    // TODO: check if tok->previous()->isCast(). can't right now because
+    //
+    // auto x = [](void *ptr) { g(ptr) };
+    // void *p = malloc(1);
+    // (x)(p);
+    // ^
+    // the lpar surrounding x has isCast() == true, so checking isCast() would
+    // have false positive leaks, while allowing casts to take ownership of
+    // resources is instead a false negative
+    if (tok->previous()->str() == "(" && !tok->previous()->isBinaryOp() &&
+        tok->linkAt(-1) && !tok->isStandardType()) {
         tok = tok->linkAt(-1)->next();
     } else if (!tok->isStandardType() && tok->isName() && tok->linkAt(1)) {
         tok = tok->linkAt(1)->next();