Skip to content

Commit 264d28e

Browse files
committed
fixed -Wlifetime-safety-cross-tu-constructor-suggestions Clang warnings
1 parent 3ac9416 commit 264d28e

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
8282
if(CMAKE_CXX_STANDARD LESS 20)
8383
add_compile_options_safe(-Wno-lifetime-safety-intra-tu-suggestions)
8484
add_compile_options_safe(-Wno-lifetime-safety-intra-tu-constructor-suggestions)
85+
add_compile_options_safe(-Wno-lifetime-safety-cross-tu-constructor-suggestions)
8586
endif()
86-
add_compile_options_safe(-Wno-lifetime-safety-cross-tu-constructor-suggestions)
8787

8888
# TODO: fix these?
8989
add_compile_options(-Wno-padded)

simplecpp.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,9 @@ namespace simplecpp {
269269
public:
270270
class Stream;
271271

272-
explicit TokenList(std::vector<std::string> &filenames);
272+
explicit TokenList(std::vector<std::string> &filenames SIMPLECPP_LIFETIMEBOUND);
273273
/** generates a token list from the given std::istream parameter */
274-
TokenList(std::istream &istr, std::vector<std::string> &filenames, const std::string &filename=std::string(), OutputList *outputList = nullptr);
274+
TokenList(std::istream &istr, std::vector<std::string> &filenames SIMPLECPP_LIFETIMEBOUND, const std::string &filename=std::string(), OutputList *outputList = nullptr);
275275
/** generates a token list from the given buffer */
276276
template<size_t size>
277277
TokenList(const char (&data)[size], std::vector<std::string> &filenames, const std::string &filename=std::string(), OutputList *outputList = nullptr)
@@ -309,7 +309,7 @@ namespace simplecpp {
309309
#endif // __cpp_lib_span
310310

311311
/** generates a token list from the given filename parameter */
312-
TokenList(const std::string &filename, std::vector<std::string> &filenames, OutputList *outputList = nullptr);
312+
TokenList(const std::string &filename, std::vector<std::string> &filenames SIMPLECPP_LIFETIMEBOUND, OutputList *outputList = nullptr);
313313
TokenList(const TokenList &other);
314314
TokenList(TokenList &&other);
315315
~TokenList();
@@ -389,7 +389,7 @@ namespace simplecpp {
389389
const std::string& file(const Location& loc) const;
390390

391391
private:
392-
TokenList(const unsigned char* data, std::size_t size, std::vector<std::string> &filenames, const std::string &filename, OutputList *outputList, int /*unused*/);
392+
TokenList(const unsigned char* data, std::size_t size, std::vector<std::string> &filenames SIMPLECPP_LIFETIMEBOUND, const std::string &filename, OutputList *outputList, int /*unused*/);
393393

394394
void combineOperators();
395395

0 commit comments

Comments
 (0)