Remove protocol version check for query parameters (#213)

* Remove protocol version check for query parameters

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

* Re-enable query parameters tests

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

---------

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

Author: kravets-levko

lib/DBSQLSession.ts

@@ -2,15 +2,13 @@ import * as fs from 'fs';
 import * as path from 'path';
 import { stringify, NIL, parse } from 'uuid';
 import fetch, { HeadersInit } from 'node-fetch';
-import { Thrift } from 'thrift';
 import {
   TSessionHandle,
   TStatus,
   TOperationHandle,
   TSparkDirectResults,
   TSparkArrowTypes,
   TSparkParameter,
-  TProtocolVersion,
 } from '../thrift/TCLIService_types';
 import { Int64 } from './hive/Types';
 import IDBSQLSession, {
@@ -98,16 +96,6 @@ function getQueryParameters(
     return [];
   }
 
-  if (
-    !sessionHandle.serverProtocolVersion ||
-    sessionHandle.serverProtocolVersion < TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V8
-  ) {
-    throw new Thrift.TProtocolException(
-      Thrift.TProtocolExceptionType.BAD_VERSION,
-      'Parameterized operations are not supported by this server. Support will begin with server version DBR 14.1',
-    );
-  }
-
   const result: Array<TSparkParameter> = [];
 
   if (namedParameters !== undefined) {

tests/e2e/query_parameters.test.js

@@ -19,9 +19,8 @@ const openSession = async () => {
   });
 };
 
-// TODO: Temporarily disable those tests until we figure out issues with E2E test env
 describe('Query parameters', () => {
-  it.skip('should use named parameters', async () => {
+  it('should use named parameters', async () => {
     const session = await openSession();
     const operation = await session.executeStatement(
       `
@@ -72,7 +71,7 @@ describe('Query parameters', () => {
     ]);
   });
 
-  it.skip('should accept primitives as values for named parameters', async () => {
+  it('should accept primitives as values for named parameters', async () => {
     const session = await openSession();
     const operation = await session.executeStatement(
       `
@@ -117,7 +116,7 @@ describe('Query parameters', () => {
     ]);
   });
 
-  it.skip('should use ordinal parameters', async () => {
+  it('should use ordinal parameters', async () => {
     const session = await openSession();
     const operation = await session.executeStatement(
       `
@@ -168,7 +167,7 @@ describe('Query parameters', () => {
     ]);
   });
 
-  it.skip('should accept primitives as values for ordinal parameters', async () => {
+  it('should accept primitives as values for ordinal parameters', async () => {
     const session = await openSession();
     const operation = await session.executeStatement(
       `